Skip to content

feat(vmm-cli): support --gpu all to attach all GPUs #457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kvinwang merged 1 commit into from
Jan 25, 2026
Merged

feat(vmm-cli): support --gpu all to attach all GPUs #457

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions vmm/src/vmm-cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -591,7 +591,7 @@ def create_vm(self, args) -> None:
if swap_bytes > 0:
params["swap_size"] = swap_bytes

if args.ppcie:
if args.ppcie or (args.gpu and "all" in args.gpu):
params["gpus"] = {
"attach_mode": "all"
}
Expand Down Expand Up @@ -831,8 +831,9 @@ def update_vm(
upgrade_params["ports"] = port_mappings

# handle GPU updates - only update if one of the GPU flags is set
if attach_all or no_gpus or gpu_slots is not None:
if attach_all:
gpu_all = gpu_slots and "all" in gpu_slots
if attach_all or gpu_all or no_gpus or gpu_slots is not None:
if attach_all or gpu_all:
gpu_config = {"attach_mode": "all"}
updates.append("GPUs (all)")
elif no_gpus:
Expand Down Expand Up @@ -1264,7 +1265,7 @@ def main():
deploy_parser.add_argument('--port', action='append', type=str,
help='Port mapping in format: protocol[:address]:from:to')
deploy_parser.add_argument('--gpu', action='append', type=str,
help='GPU slot to attach (can be used multiple times)')
help='GPU slot to attach (can be used multiple times), or "all" to attach all GPUs')
deploy_parser.add_argument('--ppcie', action='store_true',
help='Enable PPCIE (Protected PCIe) mode - attach all available GPUs')
deploy_parser.add_argument('--pin-numa', action='store_true',
Expand Down Expand Up @@ -1407,7 +1408,7 @@ def main():
"--gpu",
action="append",
type=str,
help="GPU slot to attach (can be used multiple times)",
help="GPU slot to attach (can be used multiple times), or \"all\" to attach all GPUs",
)
gpu_group.add_argument(
"--ppcie",
Expand Down