Make simulator certs more realistic#541
Merged
kvinwang merged 1 commit intoDstack-TEE:masterfrom Mar 14, 2026
Merged
Conversation
…tual TLS key
The simulator's get_tls_key RPC produced RA-TLS certificates with a canned
attestation whose report_data didn't match the actual TLS public key. Clients
verifying report_data == SHA-512("ratls-cert:" || leaf_pubkey) would reject
these certs. Fix by adding VersionedAttestation::set_report_data() and calling
it in request_cert() when an attestation override is provided.
kvinwang
approved these changes
Mar 14, 2026
Collaborator
There was a problem hiding this comment.
LGTM. Correctly updates both the struct field and raw quote bytes in sync.
Minor suggestions (non-blocking):
- The magic offset
568..632is now duplicated withsimulate_quote()— consider extracting a constant or havingsimulate_quote()callset_report_data()instead - Silently skipping when quote length < 632 could hide data corruption — consider adding a warning log
kvinwang
added a commit
that referenced
this pull request
Mar 14, 2026
Replace the duplicated magic offset `568..632` with a named constant `TDX_QUOTE_REPORT_DATA_RANGE` and add a warning log when the quote is too short to patch report_data, which would indicate data corruption. Follow-up to PR #541.
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The simulator's get_tls_key RPC produced RA-TLS certificates with a canned attestation whose report_data didn't match the actual TLS public key. Clients verifying report_data == SHA-512("ratls-cert:" || leaf_pubkey) would reject these certs. Fix by adding VersionedAttestation::set_report_data() and calling it in request_cert() when an attestation override is provided.