refactor: extract TDX quote report_data offset as a named constant#542
Merged
refactor: extract TDX quote report_data offset as a named constant#542
Conversation
Replace the duplicated magic offset `568..632` with a named constant `TDX_QUOTE_REPORT_DATA_RANGE` and add a warning log when the quote is too short to patch report_data, which would indicate data corruption. Follow-up to PR #541.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
568..632into a named constantTDX_QUOTE_REPORT_DATA_RANGEindstack-attestVersionedAttestation::set_report_data()andsimulate_quote()tracing::warn!when the TDX quote is too short to patch report_data, instead of silently skippingContext
Follow-up to #541. The magic offset was duplicated in two places and a short quote was silently ignored, which could hide data corruption.
Test plan
cargo check -p dstack-attest -p dstack-guest-agentpasses