feat(kms): enhance onboard page with site name, chain info, and k256 pubkey#571
Draft
feat(kms): enhance onboard page with site name, chain info, and k256 pubkey#571
Conversation
…pubkey Add configurable site_name, eth_rpc_url, and kms_contract_address to the onboard config, displayed on the onboard page for operator visibility. Return k256_pubkey in OnboardResponse so it can be compared with the on-chain kmsInfo.k256Pubkey after onboarding.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
site_name,eth_rpc_url, andkms_contract_addressto[core.onboard]config, displayed on the onboard page for operator visibilityk256_pubkeyinOnboardResponseso it can be compared with the on-chainkmsInfo.k256Pubkeyafter onboardingConfig Example
Test plan
site_name,eth_rpc_url,kms_contract_addressset in configk256Pubkeyis shown in the resultk256Pubkeywith on-chainkmsInfo.k256Pubkey