kms: check KMS authorization during bootstrap and onboard#573
Merged
kms: check KMS authorization during bootstrap and onboard#573
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add KMS authorization checks to bootstrap / onboard / trusted RPC flows:
BootstrapOnboardquote_enabled = falseCovered trusted RPCs
GetAppKeyGetAppEnvEncryptPubKeyGetKmsKeyGetTempCaCertSignCertDetails
This change reuses a shared
BootInfobuilder so bootstrap / onboard / runtime checks use the same attestation-derived fields as the existing KMS authorization path.The local KMS boot info is stable for the running process, so it is cached and reused across trusted RPCs. The auth decision itself is still checked on each trusted RPC.
Behavior:
quote_enabled = trueBootstrapverifies local KMS boot info and callsbootAuth/kmsOnboardverifies the source KMS attestation and callsbootAuth/kmsquote_enabled = falseValidation
Code:
cargo check -p dstack-kmscargo fmt --allcargo clippy -p dstack-kms --all-targets -- -D warningsManual integration flow:
tests/docs/kms-self-authrization.mdquote_enabled = truequote_enabled = truequote_enabled = truequote_enabled = falsequote_enabled = falseGetKmsKeypath)CC #571 — that PR also has a related guard-rail / defense-in-depth effect.