fix: report commit hashes instead of unrelated component tags#800
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the VMM’s reported revision string so it always shows an abbreviated commit hash (rather than an unrelated component tag) in the version output and UI.
Changes:
- Updates the
git_version!invocation to passgit describe --exclude=*, preventing tag-based descriptions in this monorepo. - Adds a short comment explaining why tags are excluded (component-scoped tags can be misleading for VMM).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
git_version!usesgit describe, which selects the nearest tag. Because dstack is a monorepo with component-specific tags, binaries can report an unrelated component tag. For example, VMM reportedgit:verifier-v0.5.11-..., which the UI truncated togit:verifier-v.Change
dstack-build-infocrate;git_revision!()macro with the repository-wide Git revision policy;git:prefix, dirty suffix, and fallback behavior;Validation