fix(vmm): authorize bridge networking requests - #835
Closed
kvinwang wants to merge 3 commits into
Closed
Conversation
This was referenced Jul 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
allowed_modesandallowed_bridgespolicy to VMM networking configurationSecurity invariant delivered by this PR
A tenant RPC can select only a networking mode authorized by the administrator, and bridge mode can attach only to the configured default bridge or an explicitly allowlisted Linux bridge. User-controlled bridge strings no longer reach QEMU unless they are valid Linux interface names and pass both policy and sysfs bridge-type checks.
This is Phase 0 of the included design. It intentionally does not claim MAC/ARP/IP anti-spoofing yet; deterministic TAP creation and the least-privilege enforcement backend are follow-up implementation phases.
Compatibility
allowed_modespreserves the existing typed mode behaviorbridgeremains allowedallowed_bridgesnow means no additional tenant-selectable host bridgesVerification
cargo test -p dstack-vmm— 59 passedcargo clippy -p dstack-vmm --all-targets -- -D warningsgit diff --check origin/master...HEAD