[STACKED on #874] fix(kms): return Finish response before shutdown - #875
Open
kvinwang wants to merge 3 commits into
Open
[STACKED on #874] fix(kms): return Finish response before shutdown#875kvinwang wants to merge 3 commits into
kvinwang wants to merge 3 commits into
Conversation
Defect: Onboard.Finish terminated the process inside the RPC handler before Rocket could flush the documented Empty response. Observed symptom: clients received RemoteDisconnected and the graceful-response regression failed. Fix: return success immediately and schedule process exit after a short response-drain interval.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The KMS
Finishhandler exited the process before Rocket had sent the RPC response. The onboarding client saw an EOF/connection reset and could not tell whether finalization succeeded.Root cause and fix
Produce the unit JSON response first and schedule shutdown after it is transmitted.
Implementation
The branch records the following focused implementation work:
fix(kms): return Finish response before exitfix(rpc): emit empty JSON unit responsesfix(kms): shut down after Finish responseChanged paths:
dstack/kms/src/main.rsdstack/kms/src/onboard_service.rsdstack/ra-rpc/src/rocket_helper.rsScope
This PR addresses one logical
kmsfinding. It intentionally excludes the acceptance-test infrastructure from #841 and unrelated product fixes from #840.Dependency and merge order
codex/fix-kms-private-key-permissionsVerification
git diff --check origin/codex/fix-kms-private-key-permissions..origin/codex/fix-kms-finish-response-order: passed.