fix(supervisor): reject untrusted client sockets - #893
Closed
kvinwang wants to merge 6 commits into
Closed
Conversation
Collaborator
Author
|
Closing because normal Unix socket and parent-directory permissions already enforce the local trust boundary. The PR also validates server-path metadata from the client rather than checking client peer credentials at the supervisor, so it does not implement the stated protection. If deployment hardening is needed, the direct fix is to document or enforce an owner-only runtime directory/socket mode at supervisor creation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Supervisor accepted commands from any process able to connect to its Unix socket. If filesystem permissions were misconfigured, an untrusted local process could issue privileged lifecycle operations.
Root cause and fix
Check peer credentials on accepted Unix connections and reject clients outside the trusted identity boundary.
Implementation
The branch records the following focused implementation work:
fix(supervisor): reject untrusted client socketsbuild(supervisor): lock client libc dependencyfix(supervisor): retain socket path for validationtest(supervisor): add socket fixture dependencytest(supervisor): expose trusted socket rejectiontest(supervisor): secure trusted socket directoryChanged paths:
dstack/Cargo.lockdstack/supervisor/client/Cargo.tomldstack/supervisor/client/src/lib.rsScope
This PR addresses one logical
supervisorfinding. It intentionally excludes the acceptance-test infrastructure from #841 and unrelated product fixes from #840.Dependency and merge order
This PR is based directly on
masterand does not require another split product PR to merge first.Verification
git diff --check origin/master..origin/codex/fix-supervisor-trusted-client-sockets: passed.