fix(guest): disable the ZFS pool root mountpoint - #980
Open
kvinwang wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the guest storage initialization logic to ensure the ZFS pool root dataset is never mounted, preventing unintended mounts in the guest filesystem and leaving only the explicitly managed dstack/data dataset mounted at the configured mount point.
Changes:
- Create the ZFS pool with
zpool create ... -m noneso the pool root dataset hasmountpoint=none. - Keep creating
dstack/datawith an explicit mountpoint (-o mountpoint=$mount_point) as the sole mounted dataset.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A newly created ZFS pool inherits the default root-dataset mountpoint. This can mount the
dstackpool root separately from the explicitly manageddstack/datadataset, creating an unintended mount in the guest filesystem.Fix
Create the pool with
-m none, leaving the pool root unmounted. Onlydstack/data, whose mountpoint is explicitly configured by the guest setup code, is mounted.Implementation
fix(guest): disable the ZFS pool root mountpointChanged path:
dstack/dstack-util/src/system_setup.rsScope
This PR is based directly on
masterand contains only the ZFS root-mountpoint change.Verification
cargo test -p dstack-util --no-run: passedgit diff --check origin/master...HEAD: passed