fix(supervisor): reply before graceful shutdown - #995
Merged
Conversation
This was referenced Aug 4, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts the Supervisor’s HTTP shutdown endpoint to stop the Rocket server after producing a shutdown result, so clients are less likely to lose the connection due to immediate process termination. It preserves the existing “forced exit” behavior for signal-triggered shutdowns.
Changes:
- Update the
/shutdownroute to callSupervisor::shutdown()directly and only then trigger Rocket’s graceful shutdown notification. - Keep signal-triggered shutdown behavior routed through the existing forced-exit path.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
kvinwang
enabled auto-merge
August 4, 2026 11:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Return the Supervisor shutdown response before notifying Rocket to stop, so clients receive the result instead of losing the connection to an immediate process exit. Signal-triggered shutdown retains the existing forced-exit behavior.
Verification
cargo test --manifest-path dstack/Cargo.toml -p supervisorcargo fmt --manifest-path dstack/Cargo.toml --allgit diff --check