Support RetrievalMethod to obtain encrypted key - #1
Merged
Conversation
Some Identity Providers use https://www.w3.org/TR/xmldsig-core1/#sec-RetrievalMethod to deliver the encrypted key inside the same document but not inlined into KeyInfo.
RumataEstor
force-pushed
the
feature/retrieval-method
branch
from
February 25, 2020 01:28
4028fec to
b4faf38
Compare
Author
|
Running a travis build on the personal repository https://travis-ci.org/RumataEstor/esaml revealed the first test fix was unnecessary probably caused by the local environment, and also that current cowlib cannot be compiled using OTP18. |
andre-dubber
approved these changes
Feb 25, 2020
andre-dubber
left a comment
There was a problem hiding this comment.
My understanding of the Erlang is limited, but from what I understand all looks good
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The certificate details are:
The decrypted assertions are: