Fix IsPersistent issue in the session migration samples (v7 and v8) - #373
Merged
Conversation
wcabus
requested review from
ProgrammerAL and
maartenba
and removed request for
maartenba
August 6, 2026 09:22
maartenba
approved these changes
Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/orgs/DuendeSoftware/discussions/602
This pull request fixes the issue raised in the session migration sample for both v7 and v8 of IdentityServer, by copying the relevant properties from the original authentication ticket into the new server-side session.
Additionally, added some comments for folks adopting the sample in production scenario's, providing an alternative for the sync/async blocking issue etc.