Skip to content

Data pre preparation - spreadsheet data#6

Merged
zeynepaki merged 16 commits into
mainfrom
data-pre-preparation
Mar 4, 2024
Merged

Data pre preparation - spreadsheet data#6
zeynepaki merged 16 commits into
mainfrom
data-pre-preparation

Conversation

@zeynepaki

@zeynepaki zeynepaki commented Mar 1, 2024

Copy link
Copy Markdown
Contributor

@zeynepaki zeynepaki self-assigned this Mar 1, 2024
@zeynepaki zeynepaki requested a review from sjmf March 1, 2024 15:20

@sjmf sjmf left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, some changes could be made.

Comment thread README.md
Comment thread README.md Outdated

- You can create a Virtual Environment for your code using:
```
python -m venv venv

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could also do this using conda if installed:

conda create --name CASSS
conda activate CASSS
conda install pip
pip install -r requirements.txt

Not required but easy if the user already uses conda as their environment manager.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added information on this here 349ad34

Comment thread pre-preparation/condenser.py
Comment thread requirements.txt Outdated
@@ -1 +1,2 @@
pandas~=2.2.1 No newline at end of file
pandas~=2.2.1
openpyxl No newline at end of file

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add version for openpyxl.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done and dusted :) 45d74c3

@zeynepaki zeynepaki requested a review from sjmf March 2, 2024 22:24

@sjmf sjmf left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good!

@zeynepaki zeynepaki merged commit 846a010 into main Mar 4, 2024
@zeynepaki zeynepaki deleted the data-pre-preparation branch March 4, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Re-format the metadata to be suitable for training Pre-prepare spreadsheet data

2 participants