Skip to content

fix: scroll tall Confirm body inside the pink card - #29

Merged
ajlennon merged 1 commit into
mainfrom
fix/confirm-body-scrollbar
Jul 28, 2026
Merged

fix: scroll tall Confirm body inside the pink card#29
ajlennon merged 1 commit into
mainfrom
fix/confirm-body-scrollbar

Conversation

@ajlennon

Copy link
Copy Markdown
Member

Summary

  • Confirm body text now scrolls inside the pink card (title + border stay fixed), matching the Windows approach.
  • Removes the length/newline threshold and ellipsis path that left medium WhatsApp confirms cut off by the options list after fix: stop clipping Confirm card bottom border #28.
  • Short bodies still size naturally via propagate_natural_height; tall ones cap at ~180px with a scrollbar.

Test plan

  • Smoke-tested tall WhatsApp-style Confirm — scrollbar works, full text reachable
  • Short Confirm (1–2 lines) — pink border fully visible, no empty scroll chrome
  • Medium Confirm (From/To/Cc/Subject) — no clipping under options
  • Cancel/OK remain pinned and clickable

Made with Cursor

Medium WhatsApp-style confirms were crushed by the options list after #28 skipped ScrolledWindow for short/medium cards. Cap the body with an inner scrollbar so the border stays intact and full text stays reachable.

Co-authored-by: Cursor <cursoragent@cursor.com>
@ajlennon
ajlennon requested a review from jackghx as a code owner July 28, 2026 11:37
@ajlennon
ajlennon merged commit d5cebc6 into main Jul 28, 2026
4 checks passed
@ajlennon
ajlennon deleted the fix/confirm-body-scrollbar branch July 28, 2026 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant