Skip to content

fix(mcq): stop clipping Confirm question bodies - #34

Merged
ajlennon merged 1 commit into
mainfrom
fix/mcq-confirm-body-clip
Aug 5, 2026
Merged

fix(mcq): stop clipping Confirm question bodies#34
ajlennon merged 1 commit into
mainfrom
fix/mcq-confirm-body-clip

Conversation

@ajlennon

@ajlennon ajlennon commented Aug 5, 2026

Copy link
Copy Markdown
Member

Summary

  • Keep the Confirm decision-ask lead fully visible; scroll only the detail (command / To+body / meta).
  • Remeasure wrapped Gtk labels after width settles (natural-height under-count was clipping the last line without a usable scrollbar).
  • Raise the body height cap; mirror lead/detail on Windows.

Fixes Preloop Shell gates (and other tall Confirm cards) where Command: was cut off inside the pink card.

Hosts / platforms touched

  • Cursor (Linux Gtk)
  • Claude Code
  • Claude Desktop / other stdio host
  • Windows Phase 1 (tkinter text-only)
  • Docs only (no behaviour change)

Test plan

Check Result Notes
uv run python scripts/test_match_transcript.py Pass
uv run python scripts/test_doctor.py Pass
uv run python scripts/test_acks.py Pass
uv run python scripts/test_install.py Pass
uv run python scripts/test_dialog_ergonomics.py Pass includes split_lead_detail + body-cap constants
uv run python scripts/test_windows_backend.py Pass
uv run python scripts/test_contracts.py Pass
uv run python scripts/test_mcq_images.py Pass
check_setup in a real host Skip
ask_multiple_choice dialog click Pass smoke open from fixed tree
Image preview in Gtk dialog (image/images) Skip unchanged
Keyboard 1–8 / Enter / Esc Skip unchanged
Freeform / Something else Skip unchanged
Speak / duck (if claiming voice) Skip text-only

Environment: Ubuntu, Cursor, DISPLAY=:0, text-only MCQ (ASK_QUESTION_AUDIO=0).

Behaviour contract

  • No removal/rename of MCP tools without a migration note
  • Cursor absolute-uv docs kept
  • No lab IPs / home paths / secrets in tracked files
  • If adding a host: N/A

AI assistance

  • AI-assisted (Cursor) — verified unit ergonomics suite + dialog smoke open; human MCQ-approved create/merge

Keep the decision-ask lead fully visible, remasure wrapped detail under a
taller height cap, and mirror lead/detail on Windows so shell gates no longer
hide the Command line inside the pink card.

Co-authored-by: Cursor <cursoragent@cursor.com>
@ajlennon
ajlennon requested a review from jackghx as a code owner August 5, 2026 06:33
@ajlennon
ajlennon merged commit 657e13f into main Aug 5, 2026
3 of 4 checks passed
@ajlennon
ajlennon deleted the fix/mcq-confirm-body-clip branch August 5, 2026 06:36
theoriginalcheese pushed a commit to theoriginalcheese/ask-question-mcp that referenced this pull request Aug 5, 2026
Clears PYSEC-2026-3552 so the CRA audit job can go green after PR DynamicDevices#34.

Co-authored-by: Cursor <cursoragent@cursor.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant