Skip to content

Fix Rubocop warnings from the todo list - #1035

Merged
andrykonchin merged 17 commits into
masterfrom
ak/fix-rubocop-warnings-from-todo-list
Aug 1, 2026
Merged

Fix Rubocop warnings from the todo list#1035
andrykonchin merged 17 commits into
masterfrom
ak/fix-rubocop-warnings-from-todo-list

Conversation

@andrykonchin

@andrykonchin andrykonchin commented Jul 30, 2026

Copy link
Copy Markdown
Member

Changes:

  • fixed Rubocop warnings locked in the .rubocop_todo.yml file
  • refactored specs to check actual request body instead of relying on RSpec method expectations
  • revised and merged spec/dynamoid/criteria_new_spec.rb and spec/dynamoid/criteria_spec.rb files

@andrykonchin
andrykonchin force-pushed the ak/fix-rubocop-warnings-from-todo-list branch from b916f28 to 6a9649b Compare August 1, 2026 13:23
@codecov

codecov Bot commented Aug 1, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.07%. Comparing base (119628e) to head (6a9649b).
⚠️ Report is 37 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1035      +/-   ##
==========================================
+ Coverage   93.05%   93.07%   +0.02%     
==========================================
  Files          84       84              
  Lines        4448     4448              
==========================================
+ Hits         4139     4140       +1     
+ Misses        309      308       -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@andrykonchin
andrykonchin force-pushed the ak/fix-rubocop-warnings-from-todo-list branch from 6650f78 to 982fcdb Compare August 1, 2026 21:17
@andrykonchin
andrykonchin force-pushed the ak/fix-rubocop-warnings-from-todo-list branch from 982fcdb to aad8b95 Compare August 1, 2026 21:19
@andrykonchin
andrykonchin force-pushed the ak/fix-rubocop-warnings-from-todo-list branch from aad8b95 to b4d546c Compare August 1, 2026 21:31
@github-actions

github-actions Bot commented Aug 1, 2026

Copy link
Copy Markdown

Code Coverage

Package Line Rate Health
dynamoid 93%
Summary 93% (4140 / 4448)

Minimum allowed line rate is 90%

@andrykonchin
andrykonchin merged commit 150bfd1 into master Aug 1, 2026
80 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant