feat(theme): implement theme persistence, JSON parser, and IndexedDB v6 (#126) - #150
Merged
Conversation
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements Issue #126: Theme Import, Parser, and IndexedDB Persistence.
Changes
DB_VERSIONfrom 5 to 6 incore/storage.jswith additive creation ofuserThemes(keyPath: 'id') andsettings(keyPath: 'key') stores.getSettings,putSettings,saveUserThemeToDb,getUserThemeFromDb,listUserThemesFromDb, anddeleteUserThemeFromDbincore/storage.js.core/theme/themeStorage.jsproviding safe JSON theme import with 256KB length bounds and schema validation, JSON export, unified theme listing (merging built-ins with user themes), CRUD operations, and immutability protection for built-in themes.exportDatabaseandimportDatabaseincore/storage.jsto guarantee 100% lossless backup/restore of custom themes and user settings.tests/integration/storage.theme.test.mjsand updates existing storage and E2E version assertions to v6.Verification
npm run test:content: PASS (3 tests)npm run lint: PASS (0 errors)npm run test:unit: PASS (254 tests)npm run test:integration: PASS (107 tests across 11 suites)npm run test:perf: PASS (4 budget checks)npm run test:e2e: PASS (118 Playwright tests)git diff --check: Clean