Fix unsafe comment - #44
Merged
Merged
Conversation
Having a comment that ends in \ is not portable across different build systems due to the order and manner in which preprocessing is done. In some cases, like when using ninja, the \ can be interpreted as a line continuation which can silently remove the following line of code.
jgfouca
approved these changes
Jul 23, 2026
jonbob
added a commit
to E3SM-Project/E3SM
that referenced
this pull request
Jul 24, 2026
…t (PR #8582) Updating Icepack hash to main branch Updates Icepack submodule hash to point to main. The comment change introduced in #8532 changed the Icepack hash (E3SM-Project/Icepack@5d30e92) away from main. This change has been brought into the Icepack main branch in E3SM-Project/Icepack#44, so this PR has no code changes, only submodule hash update. [BFB]
jonbob
added a commit
to E3SM-Project/E3SM
that referenced
this pull request
Jul 27, 2026
Updating Icepack hash to main branch Updates Icepack submodule hash to point to main. The comment change introduced in #8532 changed the Icepack hash (E3SM-Project/Icepack@5d30e92) away from main. This change has been brought into the Icepack main branch in E3SM-Project/Icepack#44, so this PR has no code changes, only submodule hash update. [BFB]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bringing comment change introduced in E3SM-Project/E3SM#8532 into
main. Will subsequently update Icepack hash in E3SM-Project to point tomain.This change has already been brought in to CICE-Consortium/Icepack CICE-Consortium#562, noting for future sync of E3SM's Icepack.
Having a comment that ends in \ is not portable across different build systems due to the order and manner in which preprocessing is done. In some cases, like when using ninja, the \ can be interpreted as a line continuation which can silently remove the following line of code.
For detailed information about submitting Pull Requests (PRs) to the CICE-Consortium,
please refer to: https://github.com/CICE-Consortium/About-Us/wiki/Resource-Index#information-for-developers
PR checklist
ENTER INFORMATION HERE
ENTER INFORMATION HERE
ENTER INFORMATION HERE