Skip to content

Adds error check to IOStream for FileFreq options#457

Merged
philipwjones merged 1 commit into
E3SM-Project:developfrom
philipwjones:omega/iostream-append-fix
Jul 3, 2026
Merged

Adds error check to IOStream for FileFreq options#457
philipwjones merged 1 commit into
E3SM-Project:developfrom
philipwjones:omega/iostream-append-fix

Conversation

@philipwjones

@philipwjones philipwjones commented Jul 2, 2026

Copy link
Copy Markdown

When append mode is used, the FileFreq options must be supplied but an error check was missing to detect this case. User documentation was also revised to note the requirement and add some instructions for handling a special case.

Fixes #407

Checklist

  • Documentation:
  • Linting
  • Building
    • CMake build does not produce any new warnings from changes in this PR
  • Testing
    • Add a comment to the PR titled Testing with the following:
      • Which machines CTest unit tests
        have been run on and indicate that are all passing.
      • The Polaris omega_pr test suite
        has passed, using the Polaris e3sm_submodules/Omega baseline
      • Document machine(s), compiler(s), and the build path(s) used for -p for both the baseline (Polaris e3sm_submodules/Omega) and the PR build
      • Indicate "All tests passed" or document failing tests
      • Document testing used to verify the changes including any tests that are added/modified/impacted.

   When append mode is used, the FileFreq options must be supplied
   but an error check was missing to detect this case
   User documentation was also revised to note the requirement and
   some instructions for handling a special case.
@philipwjones philipwjones requested a review from xylar July 2, 2026 17:31
@philipwjones philipwjones self-assigned this Jul 2, 2026
@philipwjones

Copy link
Copy Markdown
Author

CTests pass on PM cpu and gpu. Also tested error case when FileFreq options missing to verify abort and error message are triggered. Built revised docs and viewed them successfully.

@xylar xylar left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed by inspection and @philipwjones's testing. Thanks @philipwjones! This looks like exactly what we need --both the error message and the updated docs.

@philipwjones philipwjones merged commit 6b31188 into E3SM-Project:develop Jul 3, 2026
1 check passed
@philipwjones philipwjones deleted the omega/iostream-append-fix branch July 3, 2026 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Output streams in append mode require FileFreq

2 participants