Skip to content

first attempt at a common staging class#209

Closed
smoors wants to merge 3 commits intoEESSI:mainfrom
smoors:test_staging
Closed

first attempt at a common staging class#209
smoors wants to merge 3 commits intoEESSI:mainfrom
smoors:test_staging

Conversation

@smoors
Copy link
Copy Markdown
Collaborator

@smoors smoors commented Nov 24, 2024

update: also added a test-agnostic sanity check to the staging class


stage_files = fixture(EESSI_CP2K_stage_input, scope='session')
srcdir = os.path.join(os.getcwd(), 'cp2k_staging', 'src')
stage_files = fixture(EESSI_Staging, scope='session', variables={'sourcesdir': srcdir})
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if this will work. If another test uses EESSI_Staging as a fixture, with scope session, will it then be run twice (i.e. once for each tests invoking it as a fixture)? Or once (because it's once per session scope)?

Also: even if it does run once per test that invokes this as fixture, it'll have the name EESSI_Staging both times, right? That could be confusing. But maybe that can be resolved by overwriting the test name through the variables construct? I don't know, I don't have much experience with variables as an argument to fixture.

Could you try to add the lammps case here as well? That would allow us to easily verify it.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed in the meeting: maybe we can do something along the lines of:

stage_files = fixture(EESSI_Staging, scope='session', variables={'sourcesdir': srcdir, 'testname': testname + '_staging'})

@casparvl
Copy link
Copy Markdown
Collaborator

Discussed, we'll use readonly_files #211 and simply accept that we cannot run from a nodelocal dir (requires adaptations according to #210 )

@casparvl casparvl closed this Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants