Skip to content

fix code style#22

Merged
boegel merged 7 commits intoEESSI:mainfrom
smoors:code_style
Mar 30, 2023
Merged

fix code style#22
boegel merged 7 commits intoEESSI:mainfrom
smoors:code_style

Conversation

@smoors
Copy link
Copy Markdown
Collaborator

@smoors smoors commented Mar 11, 2023 •
edited
Loading

  • fix code style, following recommendations of pylint.
  • remove unused functions
  • rename partitions 'cpu' and 'gpu' to 'cpu_partition' and 'gpu_partition', respectively.

casparvl
casparvl reviewed Mar 13, 2023
View reviewed changes
terjekv
terjekv reviewed Mar 14, 2023
View reviewed changes
@smoors smoors mentioned this pull request Mar 25, 2023
Merged
@boegel boegel merged commit 59f1ef3 into EESSI:main Mar 30, 2023
@boegel boegel added this to the 2023Q1 milestone May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@casparvl casparvl casparvl left review comments

@boegel boegel boegel approved these changes

+1 more reviewer

@terjekv terjekv terjekv left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2023Q1

Development

Successfully merging this pull request may close these issues.

4 participants

@smoors @boegel @terjekv @casparvl