This repository was archived by the owner on Nov 6, 2023. It is now read-only.
Merged
Conversation
Suggest RegExr, and fix minor stylistic issues.
Contributor
|
@brainwave Thanks for the update. I would prefer we not recommend RegExr, or anything else like that. It can come across like an endorsement, both us endorsing them and vice versa, which may cause problems. It might also obligate us as maintainers to help contributors troubleshoot it. (Also, I personally tend to use https://regex101.com/ for regex checking. I don't know what the other maintainers use.) Just as an FYI, you might find issue #7277 interesting, where we discussed mentioning Sublist3r, another third-party tool. |
Contributor
Author
|
Ready for re-review. |
Contributor
|
Thanks, merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Suggest RegExr, and fix minor stylistic issues.
I'm totally open to resplitting this into multiple commits, revising it, and so on. :)