Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

Conversation

@jayvdb
Copy link
Contributor

@jayvdb jayvdb commented Apr 11, 2020

Related issues: #17965 #12297

List related PRs if any

@cschanaj
Copy link
Collaborator

By convention we avoid non-capturing RegEx rules now. The non-necessary snapping rewrite can also be removed. Would you replace the existing rules with the following?

	<rule from="^http://(www\.)?4exhale\.org/"
		to="https://exhaleprovoice.org/" />
		
	<rule from="^http:" to="https:" />

@cschanaj cschanaj closed this Apr 14, 2020
@cschanaj cschanaj reopened this Apr 14, 2020
@cschanaj cschanaj self-assigned this Apr 14, 2020
@jayvdb
Copy link
Contributor Author

jayvdb commented Apr 16, 2020

Ruleset enhanced as requested @cschanaj .

@jayvdb jayvdb changed the title Unused rule exhale Exhale.xml: Fixes and enhancements Apr 16, 2020
@cschanaj cschanaj merged commit 8d8586a into EFForg:master Apr 17, 2020
@cschanaj cschanaj removed their assignment Apr 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants