Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

Conversation

@ghost
Copy link

@ghost ghost commented May 12, 2020

Delete section if irrelevant

List related PRs if any

  • pr link

List related issues if any

  • issue link

May delete note after reading

Note to contributor:

Thank you for contributing! If this is a new ruleset and your first time contributing, congratulations! There will be some tests ran through our continuous integration in Travis. For example, checking for duplicate hosts, problematic hosts, etc. in the ruleset file. You will see this testing begin when you open this pull request.

If this is not your first time and you have open PRs that have not been closed or merged, please revisit them by searching: https://github.com/EFForg/https-everywhere/issues?q=is%3Aopen+assignee%3A[yourusernamehere]. If there is something not being addressed by other maintainers or a project lead, link them to the PR with your question. Thank you for your patience.

More helpful filters in Pull Request search:

  • Changes requested:
    is:pr is:open type:pr review:changes_requested author:[your username]
  • Updated from specific date:
    is:pr updated:>yyyy-mm-dd
  • Merged PRs:
    is:pr is:merged author:[your username]
  • Approved PRs:
    is:pr review:approved author:[your username]

@ivysrono ivysrono added china Label for Mainland China websites top-100 labels May 12, 2020
@ivysrono ivysrono merged commit ed241b3 into EFForg:master May 12, 2020
@ghost ghost deleted the patch-2 branch May 12, 2020 15:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

china Label for Mainland China websites top-100

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant