This repository was archived by the owner on Nov 6, 2023. It is now read-only.
Chrome: Streamline redirect counter #199
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(For issue #12) This refactors & optimizes the old redirect counter. The redirect counter exits to catch infinite HTTPS <-> HTTP loops. The old counter was messy, constantly churning a small array of requestIds. I think it was written before the new API call: onBeforeRedirect. (The old counter also generated a lot of orphan entries, e.g. when another extension or the browser itself aborted requests / redirected to about:blank.) Signed-off-by: Nick Semenkovich <semenko@alum.mit.edu>
diracdeltas
added a commit
that referenced
this pull request
Apr 4, 2014
Chrome: Streamline redirect counter
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(For issue #12)
This refactors & optimizes the old redirect counter.
The redirect counter exits to catch infinite HTTPS <-> HTTP loops. The old counter
was messy, constantly churning a small array of requestIds. I think it was written
before the new API call: onBeforeRedirect.
(The old counter also generated a lot of orphan entries, e.g. when another
extension or the browser itself aborted requests / redirected to about:blank.)
Signed-off-by: Nick Semenkovich semenko@alum.mit.edu