This repository was archived by the owner on Nov 6, 2023. It is now read-only.
Remove Cloudflare __cfduid cookie configs #20071
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This cookie is no longer set for any requests proxied via Cloudflare and thus the configs that were added for it can be removed. Further context from Cloudflare's blog: https://blog.cloudflare.com/deprecating-cfduid-cookie/
Contributor
Author
|
Getting this in the build that failed: This is unrelated to the PR, but the certificate they are serving at time of posting is indeed expired, should I also change the https rule? |
Contributor
|
@migueldemoura Yes, go ahead and remove those domains from the rule. The PR should build fine afterwards. |
The hosts related to placehold.it are no longer serving a valid certificate so the https rule for them no longer makes sense.
Contributor
Author
|
Thanks @zoracon, I've removed the |
zoracon
approved these changes
Jun 1, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cookie is no longer set for any requests proxied via Cloudflare and
thus the configs that were added for it can be removed.
Further context from Cloudflare's blog:
https://blog.cloudflare.com/deprecating-cfduid-cookie/
Not sure if the
nameattribute of<securecookie>always has to be a regex, but if not then you could simplify some of the expressions down to a straight strncmp.Type of change