Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

Conversation

@mrPjer
Copy link
Contributor

@mrPjer mrPjer commented Apr 30, 2017

This is the official website of the Faculty of Electrical Engineering
and Computing in Zagreb, Croatia. The site supports HTTPS, but defaults
to HTTP, unless the user goes through the log in flow.

This is the official website of the Faculty of Electrical Engineering
and Computing in Zagreb, Croatia. The site supports HTTPS, but defaults
to HTTP, unless the user goes through the log in flow.
@J0WI
Copy link
Contributor

J0WI commented May 30, 2017

Can we expand the coverage of this ruleset to other hosts in *.unizg.hr?
See https://github.com/EFForg/https-everywhere/blob/master/CONTRIBUTING.md#enumerating-subdomains

@mrPjer
Copy link
Contributor Author

mrPjer commented Jun 5, 2017

We can, but we'll have to add them manually as not all of them support HTTPS properly.

I'll expand the ruleset next week with other hosts I'm aware of that support HTTPS.

@jeremyn
Copy link
Contributor

jeremyn commented Dec 5, 2017

@mrPjer Are you still interested in working on this pull request?

@mrPjer
Copy link
Contributor Author

mrPjer commented Dec 6, 2017

I'll update the pull request over the weekend with the additional rules.

@jeremyn
Copy link
Contributor

jeremyn commented Dec 6, 2017

It looks like there are a lot of subdomains for unizg.hr, which is common for a university. I suggest creating a PR with just ^, www, and maybe 10-30 other high-priority subdomains you want to cover, and add (partial) to the ruleset name. It will be difficult for you to get a PR approved with hundreds of subdomains, because huge PRs are very tedious to review.

@mrPjer
Copy link
Contributor Author

mrPjer commented Dec 11, 2017

I've expanded the ruleset to a few more hosts that I could find and verify that they work.

@jeremyn
Copy link
Contributor

jeremyn commented Dec 11, 2017

Please sort your domains in the order described in CONTRIBUTING.md#target-ordering. Also, please mention unizg.hr and www.unizg.hr in a top comment as described in CONTRIBUTING.md#non-working-hosts.

After you've done that, I'll take a closer look. There may be other things that need to be changed.

@jeremyn jeremyn self-assigned this Dec 11, 2017
@mrPjer
Copy link
Contributor Author

mrPjer commented Dec 11, 2017

Updated. Let me know if there's anything else.

@jeremyn
Copy link
Contributor

jeremyn commented Dec 13, 2017

  • Please use this instead, with filename Unizg.hr.xml :
<!--
	Invalid certificate:
		unizg.hr
		fer.unizg.hr

	Refused:
		www.unizg.hr

-->
<ruleset name="Unizg.hr (partial)">
	<target host="www.fer.unizg.hr" />

	<target host="ferko.fer.hr" />

	<target host="ffzg.unizg.hr" />
	<target host="www.ffzg.unizg.hr" />

	<!-- pmf.unizg.hr is not in DNS -->
	<target host="www.pmf.unizg.hr" />

	<!-- vef.unizg.hr is not in DNS -->
	<target host="www.vef.unizg.hr" />

	<target host="vojni.unizg.hr" />

	<rule from="^http:" to="https:" />
</ruleset>

and please let me know if you have any questions.

@mrPjer
Copy link
Contributor Author

mrPjer commented Dec 13, 2017

Thanks for the feedback! Updated per comment. Let me know if there's anything else I can improve.

@jeremyn jeremyn merged commit bdef1a4 into EFForg:master Dec 14, 2017
@jeremyn
Copy link
Contributor

jeremyn commented Dec 14, 2017

That's it, thanks. Merged.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants