Move creation of the diag device into read thread#1007
Merged
untitaker merged 1 commit intoEFForg:mainfrom Apr 26, 2026
Merged
Conversation
Moved the creation of the DiagDevice into the diag read task thread.
8 tasks
untitaker
approved these changes
Apr 26, 2026
Collaborator
1 task
Contributor
Author
LOL, which, of course, is what I've got. 😉 No worries, if you have some other poor soul on Ubuntu or some other distro that decides it doesn't really need all the cross-compilers, I'd be happy to help them out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moved the creation of the DiagDevice into the diag read task thread.
This is a redo of #1004, per request from @untitaker, making the creation and initialization of the diag device async.
Side note: ran into some issues due to the advent of the WiFi tools, specifically the
wpa-supplicant:arm-linux-musleabihf-gcccross-compiler, which isn't available on Ubuntu. Had to build and install one using https://github.com/richfelker/musl-cross-make/. If you all think it would be useful, I can document the process in case someone else comes across the same issue.wpa-supplicantcode still wouldn't build, nor would it give me an error as to why. Digging in, I discovered that it was because the config step in the shell script was failing due to my not havingbisonandflexinstalled. It failed silently due to this line. Once I figured that out and installed the two packages, everything built.Testing as before, everything comes up quickly enough that you can watch the device retry failures in the logs in the web UI as they're happening.
Pull Request Checklist
cargo fmt.You must check one of: