Make WiFi tools optional on the orbic installer too#1009
Merged
Conversation
This is a followup to #995 That PR only made building wpa-supplicant optional for developers who effectively test their changes on tplink. Anybody who uses orbic in dev still had to have a crosscompiler (#1007 (comment)) This PR now actually makes WiFi tools optional within the orbic installer too. That step is just skipped entirely if wpa supplicant wasn't built.
Collaborator
Author
|
@jacklund I think that should fix it. |
Contributor
|
Tested on my setup by removing the cross-compiler dir from my path, and it worked. I still got the following warnings: and but it installed without any issues!! Thanks @untitaker! |
cooperq
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a followup to #995
That PR only made building wpa-supplicant optional for developers who
effectively test their changes on tplink. Anybody who uses orbic in dev
still had to have a crosscompiler
(#1007 (comment))
This PR now actually makes WiFi tools optional within the orbic
installer too. That step is just skipped entirely if wpa supplicant
wasn't built.