Skip to content
This repository was archived by the owner on Aug 2, 2022. It is now read-only.

Conversation

@dixia
Copy link
Contributor

@dixia dixia commented Feb 18, 2020

update getting started link

Change Description

update getting started link

Consensus Changes

  • Consensus Changes

API Changes

  • API Changes

Documentation Additions

  • Documentation Additions

heifner and others added 30 commits January 2, 2020 12:23
Propagate exceptions out push_block - 1.8
Propagate exceptions out push_block - 2.0
The multiversion protocol test does not work outside of the CI/CD
environment.  Add "ENABLE_MULTIVERSION_PROTOCOL_TEST" -D flag to
CMakeLists, defaulting to false, and enable it in CI/CD build script.
The multiversion protocol test does not work outside of the CI/CD
environment.  Add "ENABLE_MULTIVERSION_PROTOCOL_TEST" -D flag to
CMakeLists, defaulting to false, and enable it in CI/CD build script.
….x-8353

Make multiversion protocol test conditional.
heifner and others added 19 commits February 6, 2020 17:34
Skip sync from genesis and resume from state test on tagged builds
[2.0.x] Actions for community PRs.
Init net_plugin member variables - 2.0
brew no longer has the package and it's not needed anyways
AFAIK eosio will no longer build on anything less than 10.14 because of std::variant usage
remove brew's python@2 install - 2.0
bump script's macos version check to 10.14 - 2.0
- Add deadline to base58 encoding.

Co-Authored-By: Kevin Heifner <heifnerk@objectcomputing.com>
update  getting started link
@dixia dixia requested a review from lparisc February 18, 2020 08:41
Copy link
Contributor

@heifner heifner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Target release/2.0.x & develop

@lparisc
Copy link
Contributor

lparisc commented Feb 18, 2020

Target release/2.0.x & develop

Agreed, PRs don't go to master directly.

@dixia dixia changed the base branch from master to release/2.0.x February 24, 2020 03:42
@dixia
Copy link
Contributor Author

dixia commented Feb 24, 2020

hi thanks for hint guys 👍

which one is more preferred between release/2.0.x and develop given only one can be chosen?

@dixia dixia changed the base branch from release/2.0.x to develop February 24, 2020 03:45
@heifner
Copy link
Contributor

heifner commented Feb 24, 2020

hi thanks for hint guys 👍

which one is more preferred between release/2.0.x and develop given only one can be chosen?

Please create two PRs one targeted to release/2.0.x and one to develop

Copy link
Contributor

@lparisc lparisc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dixia please recreate this PR off develop directly then cherry-pick the commits you made to your get-started-patch-link branch; repeat for release/2.0.x. Rebasing from master to develop is not a good idea here due to the large number of commits required to catch up your master-based branch with develop.

@dixia dixia closed this Feb 27, 2020
@dixia dixia deleted the get-started-patch-link branch February 27, 2020 02:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.