Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## latest #3196 +/- ##
==========================================
- Coverage 72.92% 72.92% -0.01%
==========================================
Files 436 436
Lines 106038 106087 +49
Branches 17071 17077 +6
==========================================
+ Hits 77329 77364 +35
- Misses 28433 28447 +14
Partials 276 276 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
fwesselm
left a comment
There was a problem hiding this comment.
Thank you, @Opt-Mucca, the changes are fine. Would it make sense to have a method for this? See here.
|
@fwesselm I'm not sure whether the others can trigger, but I very much like having a function for this, and it's way safer than the existing assert! I'm super happy if you swap this PR for your changes. |
@Opt-Mucca, I could just pull my branch into this one, if that is OK for you. |
|
@fwesselm sounds good! |
This fixes the bug presented in #3190
What I think the problem is: A bug was fixed in #3149 to stop conflict analysis dropping an explanation that would've invalidated the conflict. This somehow has lead to the chain of conflicts exhausting itself, and having no guards against it stuff gets a bit funny when a
-1index appears. My change just returnsfalsewhen this happens.