Various improvements for highspy - #3257
Draft
mathgeekcoder wants to merge 2 commits into
Draft
Conversation
* fixed #3251 HandleUserInterrupt setter * changed callback handler from `list` to `set` to avoid repeated calls to same code * improved unit tests as per discussion in #3228 * cleaned up code per updated linter (Ruff) rules * added HighsError and HighsStatusError exceptions * added support for min/max with constant objective (e.g., h.minimize(4)). Low priority, but shouldn't have been an error before.
Collaborator
Author
|
Note to self: when changing callbacks from This assumption was exploited in the I don't think we should ever assume a guaranteed order, but I can also replace |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## latest #3257 +/- ##
==========================================
- Coverage 73.27% 73.26% -0.01%
==========================================
Files 445 445
Lines 108191 108185 -6
Branches 17344 17341 -3
==========================================
- Hits 79274 79259 -15
- Misses 28641 28650 +9
Partials 276 276 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…ess via `dict` on `user_callback_data`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Various improvements for highspy:
HandleUserInterruptsetter and changed callback handler fromlisttosetto avoid repeated calls to same codee.g., h.minimize(4)). Very low priority; but shouldn't give an errorChecklist
latestbranchRelated issue
Closes #3251 and #3228 (flaky tests discussion)