Skip to content

fix(association): a figure counted as none comes off the band - #1182

Merged
ExtraToast merged 1 commit into
mainfrom
fix/drop-counted-zero-figure
Sep 6, 2026
Merged

fix(association): a figure counted as none comes off the band#1182
ExtraToast merged 1 commit into
mainfrom
fix/drop-counted-zero-figure

Conversation

@ExtraToast

@ExtraToast ExtraToast commented Sep 6, 2026

Copy link
Copy Markdown
Contributor

What

The number band leaves out a figure the api counted as zero. Found while checking main's renders: /membership read 0 Events in the past year, because the dev database holds no events at all and /statistics/association answers eventsLastYear: 0.

Why not the floor

FLOORS already covers the case where the api has not answered — the page stands on a number the association publishes about itself and marks it 20+. A counted zero is a different thing: it has been counted, and printing 20+ there would be a claim the api has just contradicted. So the figure comes off the band rather than falling back.

The band now draws what it is given rather than a fixed four; the grid closes up around the gap.

Checks

254 unit tests across the association domain and the pages pass, including two new cases: a figure counted as none is left out, and one nobody has counted yet keeps its floor. Verified live — the band shows 200+ Members, 11 Esports teams this season, 16 Member-run committees, with the zero gone.

The membership e2e suite passes 24/25; the failure is does not animate the pitch in for a visitor who asked for less motion, which fails identically on stock main and is what #1151 is open for.


Diff breakdown added removed, scaled to the largest row.

frontend                                           +33     -6    3
  production         ██████████████████░░░░░░░░    +14     -6    2
  unit tests         █████████████████████████     +19     -0    1

──────────────────────────────────────────────────────────────────
production                                         +14     -6
tests                                              +19     -0  1.36 test lines per prod line
total (hand-written)                               +33     -6  3 files

The membership page read `0 Events in the past year` wherever the api counted
none. A page selling the association is the last place to print a zero.

The published floor is not the answer either: a floor stands for a number nobody
has counted yet, and a counted zero has been counted. The figure comes off the
band instead and the ones either side of it close up, so the band draws what it
is given rather than a fixed four.
@ExtraToast
ExtraToast merged commit 3045a3c into main Sep 6, 2026
41 of 42 checks passed
@ExtraToast
ExtraToast deleted the fix/drop-counted-zero-figure branch September 6, 2026 10:19
@github-actions github-actions Bot mentioned this pull request Sep 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant