sima0_20_002: Add defaults for BAM aerosols in CAM4 F-compsets; support sim_year for climatological year - #545
Merged
Conversation
jimmielin
had a problem deploying
to
CI-tests-on-CIRRUS
August 24, 2026 17:36 — with
GitHub Actions
Error
jimmielin
added a commit
to ESCOMP/atmospheric_physics
that referenced
this pull request
Aug 24, 2026
Tag name (The PR title should also include the tag name): Originator(s): @jimmielin verified by `claude-opus-5` Description (include issue title and the keyword ['closes', 'fixes', 'resolves'] and issue number): - Add defaults for `sim_year = 1850`. This attribute requires ESCOMP/CAM-SIMA#545 companion PR. List all namelist files that were added or changed: ``` M schemes/chemistry/prescribed_aerosol_deposition_flux_namelist.xml M schemes/chemistry/prescribed_aerosols_namelist.xml M schemes/chemistry/prescribed_ozone_namelist.xml M schemes/radiation_utils/prescribe_radiative_gas_concentrations_namelist.xml M schemes/radiation_utils/solar_irradiance_data_namelist.xml - populate 1850 defaults ``` List all files eliminated and why: List all files added and what they do: List all existing files that have been modified, and describe the changes: (Helpful git command: `git diff --name-status main...<your_branch_name>`) List all automated tests that failed, as well as an explanation for why they weren't fixed: Is this an answer-changing PR? If so, is it a new physics package, algorithm change, tuning change, etc? Yes, F1850 update If yes to the above question, describe how this code was validated with the new/modified features: Co-authored-by: Haipeng Lin <hplin@ucar.edu>
jimmielin
had a problem deploying
to
CI-tests-on-CIRRUS
August 24, 2026 17:57 — with
GitHub Actions
Error
nusbaume
approved these changes
Aug 24, 2026
jimmielin
requested a deployment
to
CI-tests-on-CIRRUS
August 24, 2026 18:00 — with
GitHub Actions
Waiting
peverwhee
approved these changes
Aug 24, 2026
nusbaume
pushed a commit
to nusbaume/CAM-SIMA
that referenced
this pull request
Aug 28, 2026
…rt sim_year for climatological year (ESCOMP#545) Tag name (required for release branches): sima0_20_002 Originator(s): @jimmielin AI tools used (if applicable; please also add the "AI-generated code" label to the PR): What: Claude Code `claude-fable-5`, `claude-opus-5` How: triaged rad_aer_climate issue. verified populated values matched CAM Description (include the issue title, and the keyword ['closes', 'fixes', 'resolves'] followed by the issue number): Companion PR to ESCOMP/atmospheric_physics#439 Describe any changes made to build system: see below; added `CAM_SIM_YEAR` support Describe any changes made to the namelist: namelist defaults were updated to include BAM by default and fix UNSET/'' empty-string for rad_aer_ values List any changes to the defaults for the input datasets (e.g. boundary datasets): List all files eliminated and why: List all files added and what they do: List all existing files that have been modified, and describe the changes: (Helpful git command: `git diff --name-status development...<your_branch_name>`) ``` M cime_config/cam_config.py M cime_config/config_component.xml M test/unit/python/test_cam_config.py - support sim_year attribute for namelist defaults M cime_config/namelist_definition_cam.xml - add defaults for rad_aer_climate for CAM4 ``` If there are new failures (compared to the `test/existing-test-failures.txt` file), have them OK'd by the gatekeeper, note them here, and add them to the file. If there are baseline differences, include the test and the reason for the diff. What is the nature of the change? Roundoff? derecho/intel/aux_sima: ``` SMS_D_Ln9.ne3pg3_ne3pg3_mt233.F1850_C4.derecho_intel.cam-outfrq_se_cam4 (Overall: DIFF) details: FAIL SMS_D_Ln9.ne3pg3_ne3pg3_mt233.F1850_C4.derecho_intel.cam-outfrq_se_cam4 NLCOMP FAIL SMS_D_Ln9.ne3pg3_ne3pg3_mt233.F1850_C4.derecho_intel.cam-outfrq_se_cam4 BASELINE /glade/campaign/cesm/community/amwg/sima_baselines/latest_intel: DIFF SMS_D_Ln9.ne3pg3_ne3pg3_mt233.F2000_C4.derecho_intel.cam-outfrq_se_cam4 (Overall: DIFF) details: FAIL SMS_D_Ln9.ne3pg3_ne3pg3_mt233.F2000_C4.derecho_intel.cam-outfrq_se_cam4 NLCOMP FAIL SMS_D_Ln9.ne3pg3_ne3pg3_mt233.F2000_C4.derecho_intel.cam-outfrq_se_cam4 BASELINE /glade/campaign/cesm/community/amwg/sima_baselines/latest_intel: DIFF - updates to namelist defaults to include BAM - for F1850, updates to atmos_phys namelist defaults for 1850 era GHGs and prescribed datasets SMS_D_Ln9.mpasa120_mpasa120.QPC4.derecho_intel.cam-outfrq_analy_ic_cam4 (Overall: NLFAIL) details: FAIL SMS_D_Ln9.mpasa120_mpasa120.QPC4.derecho_intel.cam-outfrq_analy_ic_cam4 NLCOMP SMS_D_Ln9.ne3pg3_ne3pg3_mt233.QPC4.derecho_intel.cam-outfrq_se_cam4 (Overall: NLFAIL) details: FAIL SMS_D_Ln9.ne3pg3_ne3pg3_mt233.QPC4.derecho_intel.cam-outfrq_se_cam4 NLCOMP SMS_Ln9.mpasa120_mpasa120.QPC4.derecho_intel.cam-outfrq_analy_ic_cam4 (Overall: NLFAIL) details: FAIL SMS_Ln9.mpasa120_mpasa120.QPC4.derecho_intel.cam-outfrq_analy_ic_cam4 NLCOMP SMS_Ln9.mpasa480_mpasa480.FKESSLER.derecho_intel.cam-outfrq_kessler_mpas_derecho (Overall: NLFAIL) details: FAIL SMS_Ln9.mpasa480_mpasa480.FKESSLER.derecho_intel.cam-outfrq_kessler_mpas_derecho NLCOMP SMS_Ln9.mpasa480_mpasa480.FKESSLER.derecho_intel.cam-outfrq_kessler_mpas_derecho_history (Overall: NLFAIL) details: FAIL SMS_Ln9.mpasa480_mpasa480.FKESSLER.derecho_intel.cam-outfrq_kessler_mpas_derecho_history NLCOMP SMS_Ln9.ne3pg3_ne3pg3_mg37.FADIAB.derecho_intel.cam-outfrq_se_cslam (Overall: NLFAIL) details: FAIL SMS_Ln9.ne3pg3_ne3pg3_mg37.FADIAB.derecho_intel.cam-outfrq_se_cslam NLCOMP SMS_Ln9.ne3pg3_ne3pg3_mg37.FHS94.derecho_intel.cam-outfrq_se_cslam (Overall: NLFAIL) details: FAIL SMS_Ln9.ne3pg3_ne3pg3_mg37.FHS94.derecho_intel.cam-outfrq_se_cslam NLCOMP SMS_Ln9.ne3pg3_ne3pg3_mg37.FKESSLER.derecho_intel.cam-outfrq_se_cslam (Overall: NLFAIL) details: FAIL SMS_Ln9.ne3pg3_ne3pg3_mg37.FKESSLER.derecho_intel.cam-outfrq_se_cslam NLCOMP SMS_Ln9.ne3pg3_ne3pg3_mg37.FTJ16.derecho_intel.cam-outfrq_se_cslam (Overall: NLFAIL) details: FAIL SMS_Ln9.ne3pg3_ne3pg3_mg37.FTJ16.derecho_intel.cam-outfrq_se_cslam NLCOMP SMS_Ln9.ne3pg3_ne3pg3_mt233.QPC4.derecho_intel.cam-outfrq_se_cam4 (Overall: NLFAIL) details: FAIL SMS_Ln9.ne3pg3_ne3pg3_mt233.QPC4.derecho_intel.cam-outfrq_se_cam4 NLCOMP SMS_Ln9.ne3pg3_ne3pg3_mg37.FKESSLER.derecho_intel.cam-outfrq_se_cslam_multitape (Overall: NLFAIL) details: FAIL SMS_Ln9.ne3pg3_ne3pg3_mg37.FKESSLER.derecho_intel.cam-outfrq_se_cslam_multitape NLCOMP - pre-existing failure requiring CIME update SMS_Ln9.ne3pg3_ne3pg3_mg37.F2000_C7.derecho_intel.cam-outfrq_se_cslam_analy_ic (Overall: FAIL) details: FAIL SMS_Ln9.ne3pg3_ne3pg3_mg37.F2000_C7.derecho_intel.cam-outfrq_se_cslam_analy_ic SETUP - pre-existing failure since PUMAS round 3 CAM-SIMA has not merged in registry chgs ``` derecho/gnu/aux_sima: ``` SMS_D_Ln9.ne3pg3_ne3pg3_mt233.F1850_C4.derecho_gnu.cam-outfrq_se_cam4 (Overall: DIFF) details: FAIL SMS_D_Ln9.ne3pg3_ne3pg3_mt233.F1850_C4.derecho_gnu.cam-outfrq_se_cam4 NLCOMP FAIL SMS_D_Ln9.ne3pg3_ne3pg3_mt233.F1850_C4.derecho_gnu.cam-outfrq_se_cam4 BASELINE /glade/campaign/cesm/community/amwg/sima_baselines/latest_gnu: DIFF SMS_D_Ln9.ne3pg3_ne3pg3_mt233.F2000_C4.derecho_gnu.cam-outfrq_se_cam4 (Overall: DIFF) details: FAIL SMS_D_Ln9.ne3pg3_ne3pg3_mt233.F2000_C4.derecho_gnu.cam-outfrq_se_cam4 NLCOMP FAIL SMS_D_Ln9.ne3pg3_ne3pg3_mt233.F2000_C4.derecho_gnu.cam-outfrq_se_cam4 BASELINE /glade/campaign/cesm/community/amwg/sima_baselines/latest_gnu: DIFF - updates to namelist defaults to include BAM - for F1850, updates to atmos_phys namelist defaults for 1850 era GHGs and prescribed datasets SMS_D_Ln9.mpasa120_mpasa120.QPC4.derecho_gnu.cam-outfrq_analy_ic_cam4 (Overall: NLFAIL) details: FAIL SMS_D_Ln9.mpasa120_mpasa120.QPC4.derecho_gnu.cam-outfrq_analy_ic_cam4 NLCOMP SMS_D_Ln9.ne3pg3_ne3pg3_mt233.QPC4.derecho_gnu.cam-outfrq_se_cam4 (Overall: NLFAIL) details: FAIL SMS_D_Ln9.ne3pg3_ne3pg3_mt233.QPC4.derecho_gnu.cam-outfrq_se_cam4 NLCOMP SMS_Ln2.ne3pg3_ne3pg3_mg37.FPHYStest.derecho_gnu.cam-outfrq_beljaars_derecho (Overall: NLFAIL) details: FAIL SMS_Ln2.ne3pg3_ne3pg3_mg37.FPHYStest.derecho_gnu.cam-outfrq_beljaars_derecho NLCOMP SMS_Ln2.ne3pg3_ne3pg3_mg37.FPHYStest.derecho_gnu.cam-outfrq_dme_adjust_derecho (Overall: NLFAIL) details: FAIL SMS_Ln2.ne3pg3_ne3pg3_mg37.FPHYStest.derecho_gnu.cam-outfrq_dme_adjust_derecho NLCOMP SMS_Ln2.ne3pg3_ne3pg3_mg37.FPHYStest.derecho_gnu.cam-outfrq_gw_cam4_derecho (Overall: NLFAIL) details: FAIL SMS_Ln2.ne3pg3_ne3pg3_mg37.FPHYStest.derecho_gnu.cam-outfrq_gw_cam4_derecho NLCOMP SMS_Ln2.ne3pg3_ne3pg3_mg37.FPHYStest.derecho_gnu.cam-outfrq_gw_cam7_derecho (Overall: NLFAIL) details: FAIL SMS_Ln2.ne3pg3_ne3pg3_mg37.FPHYStest.derecho_gnu.cam-outfrq_gw_cam7_derecho NLCOMP SMS_Ln2.ne3pg3_ne3pg3_mg37.FPHYStest.derecho_gnu.cam-outfrq_hack_shallow_derecho (Overall: NLFAIL) details: FAIL SMS_Ln2.ne3pg3_ne3pg3_mg37.FPHYStest.derecho_gnu.cam-outfrq_hack_shallow_derecho NLCOMP SMS_Ln2.ne3pg3_ne3pg3_mg37.FPHYStest.derecho_gnu.cam-outfrq_hb_vdiff_derecho (Overall: NLFAIL) details: FAIL SMS_Ln2.ne3pg3_ne3pg3_mg37.FPHYStest.derecho_gnu.cam-outfrq_hb_vdiff_derecho NLCOMP SMS_Ln2.ne3pg3_ne3pg3_mg37.FPHYStest.derecho_gnu.cam-outfrq_held_suarez_derecho (Overall: NLFAIL) details: FAIL SMS_Ln2.ne3pg3_ne3pg3_mg37.FPHYStest.derecho_gnu.cam-outfrq_held_suarez_derecho NLCOMP SMS_Ln2.ne3pg3_ne3pg3_mg37.FPHYStest.derecho_gnu.cam-outfrq_kessler_derecho (Overall: NLFAIL) details: FAIL SMS_Ln2.ne3pg3_ne3pg3_mg37.FPHYStest.derecho_gnu.cam-outfrq_kessler_derecho NLCOMP SMS_Ln2.ne3pg3_ne3pg3_mg37.FPHYStest.derecho_gnu.cam-outfrq_microp_aero_bam_derecho (Overall: NLFAIL) details: FAIL SMS_Ln2.ne3pg3_ne3pg3_mg37.FPHYStest.derecho_gnu.cam-outfrq_microp_aero_bam_derecho NLCOMP SMS_Ln2.ne3pg3_ne3pg3_mg37.FPHYStest.derecho_gnu.cam-outfrq_rk_stratiform_derecho (Overall: NLFAIL) details: FAIL SMS_Ln2.ne3pg3_ne3pg3_mg37.FPHYStest.derecho_gnu.cam-outfrq_rk_stratiform_derecho NLCOMP SMS_Ln2.ne3pg3_ne3pg3_mg37.FPHYStest.derecho_gnu.cam-outfrq_rrtmgp_derecho (Overall: NLFAIL) details: FAIL SMS_Ln2.ne3pg3_ne3pg3_mg37.FPHYStest.derecho_gnu.cam-outfrq_rrtmgp_derecho NLCOMP SMS_Ln2.ne3pg3_ne3pg3_mg37.FPHYStest.derecho_gnu.cam-outfrq_tj2016_after_coupler_derecho (Overall: NLFAIL) details: FAIL SMS_Ln2.ne3pg3_ne3pg3_mg37.FPHYStest.derecho_gnu.cam-outfrq_tj2016_after_coupler_derecho NLCOMP SMS_Ln2.ne3pg3_ne3pg3_mg37.FPHYStest.derecho_gnu.cam-outfrq_tj2016_before_coupler_derecho (Overall: NLFAIL) details: FAIL SMS_Ln2.ne3pg3_ne3pg3_mg37.FPHYStest.derecho_gnu.cam-outfrq_tj2016_before_coupler_derecho NLCOMP SMS_Ln2.ne3pg3_ne3pg3_mg37.FPHYStest.derecho_gnu.cam-outfrq_trcdata_bam_derecho (Overall: NLFAIL) details: FAIL SMS_Ln2.ne3pg3_ne3pg3_mg37.FPHYStest.derecho_gnu.cam-outfrq_trcdata_bam_derecho NLCOMP SMS_Ln2.ne3pg3_ne3pg3_mg37.FPHYStest.derecho_gnu.cam-outfrq_uw_vdiff_derecho (Overall: NLFAIL) details: FAIL SMS_Ln2.ne3pg3_ne3pg3_mg37.FPHYStest.derecho_gnu.cam-outfrq_uw_vdiff_derecho NLCOMP SMS_Ln2.ne3pg3_ne3pg3_mg37.FPHYStest.derecho_gnu.cam-outfrq_zm_derecho (Overall: NLFAIL) details: FAIL SMS_Ln2.ne3pg3_ne3pg3_mg37.FPHYStest.derecho_gnu.cam-outfrq_zm_derecho NLCOMP SMS_Ln9.mpasa120_mpasa120.QPC4.derecho_gnu.cam-outfrq_analy_ic_cam4 (Overall: NLFAIL) details: FAIL SMS_Ln9.mpasa120_mpasa120.QPC4.derecho_gnu.cam-outfrq_analy_ic_cam4 NLCOMP SMS_Ln9.mpasa480_mpasa480.FKESSLER.derecho_gnu.cam-outfrq_kessler_mpas_derecho (Overall: NLFAIL) details: FAIL SMS_Ln9.mpasa480_mpasa480.FKESSLER.derecho_gnu.cam-outfrq_kessler_mpas_derecho NLCOMP SMS_Ln9.mpasa480_mpasa480.FKESSLER.derecho_gnu.cam-outfrq_kessler_mpas_derecho_history (Overall: NLFAIL) details: FAIL SMS_Ln9.mpasa480_mpasa480.FKESSLER.derecho_gnu.cam-outfrq_kessler_mpas_derecho_history NLCOMP SMS_Ln9.ne3pg3_ne3pg3_mg37.F2000_C7.derecho_gnu.cam-outfrq_se_cslam_analy_ic (Overall: FAIL) details: FAIL SMS_Ln9.ne3pg3_ne3pg3_mg37.F2000_C7.derecho_gnu.cam-outfrq_se_cslam_analy_ic SETUP SMS_Ln9.ne3pg3_ne3pg3_mg37.FADIAB.derecho_gnu.cam-outfrq_se_cslam (Overall: NLFAIL) details: FAIL SMS_Ln9.ne3pg3_ne3pg3_mg37.FADIAB.derecho_gnu.cam-outfrq_se_cslam NLCOMP SMS_Ln9.ne3pg3_ne3pg3_mg37.FHS94.derecho_gnu.cam-outfrq_se_cslam (Overall: NLFAIL) details: FAIL SMS_Ln9.ne3pg3_ne3pg3_mg37.FHS94.derecho_gnu.cam-outfrq_se_cslam NLCOMP SMS_Ln9.ne3pg3_ne3pg3_mg37.FKESSLER.derecho_gnu.cam-outfrq_se_cslam (Overall: NLFAIL) details: FAIL SMS_Ln9.ne3pg3_ne3pg3_mg37.FKESSLER.derecho_gnu.cam-outfrq_se_cslam NLCOMP SMS_Ln9.ne3pg3_ne3pg3_mg37.FTJ16.derecho_gnu.cam-outfrq_se_cslam (Overall: NLFAIL) details: FAIL SMS_Ln9.ne3pg3_ne3pg3_mg37.FTJ16.derecho_gnu.cam-outfrq_se_cslam NLCOMP SMS_Ln9.ne3pg3_ne3pg3_mt233.QPC4.derecho_gnu.cam-outfrq_se_cam4 (Overall: NLFAIL) details: FAIL SMS_Ln9.ne3pg3_ne3pg3_mt233.QPC4.derecho_gnu.cam-outfrq_se_cam4 NLCOMP - fix for 'UNSET' vs. '' (correct) rad_aer_climate and diag rads ``` derecho/nvhpc/aux_sima (test is run via Github workflow. Only run the test manually if we need to save new baselines): ``` SMS_Ln2.ne3pg3_ne3pg3_mg37.FPHYStest.derecho_nvhpc.cam-outfrq_rrtmgp_derecho_gpu (Overall: NLFAIL) details: FAIL SMS_Ln2.ne3pg3_ne3pg3_mg37.FPHYStest.derecho_nvhpc.cam-outfrq_rrtmgp_derecho_gpu NLCOMP - fix for 'UNSET' vs. '' (correct) rad_aer_climate and diag rads ``` If this changes climate describe any run(s) done to evaluate the new climate in enough detail that it(they) could be reproduced: Prescribed bulk aerosols now active for F-compsets of CAM4 CAM-SIMA date used for the baseline comparison tests if different than latest: --------- Co-authored-by: Haipeng Lin <hplin@ucar.edu>
nusbaume
pushed a commit
to nusbaume/atmospheric_physics
that referenced
this pull request
Aug 28, 2026
…P#439) Tag name (The PR title should also include the tag name): Originator(s): @jimmielin verified by `claude-opus-5` Description (include issue title and the keyword ['closes', 'fixes', 'resolves'] and issue number): - Add defaults for `sim_year = 1850`. This attribute requires ESCOMP/CAM-SIMA#545 companion PR. List all namelist files that were added or changed: ``` M schemes/chemistry/prescribed_aerosol_deposition_flux_namelist.xml M schemes/chemistry/prescribed_aerosols_namelist.xml M schemes/chemistry/prescribed_ozone_namelist.xml M schemes/radiation_utils/prescribe_radiative_gas_concentrations_namelist.xml M schemes/radiation_utils/solar_irradiance_data_namelist.xml - populate 1850 defaults ``` List all files eliminated and why: List all files added and what they do: List all existing files that have been modified, and describe the changes: (Helpful git command: `git diff --name-status main...<your_branch_name>`) List all automated tests that failed, as well as an explanation for why they weren't fixed: Is this an answer-changing PR? If so, is it a new physics package, algorithm change, tuning change, etc? Yes, F1850 update If yes to the above question, describe how this code was validated with the new/modified features: Co-authored-by: Haipeng Lin <hplin@ucar.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tag name (required for release branches): sima0_20_002
Originator(s): @jimmielin
AI tools used (if applicable; please also add the "AI-generated code" label to the PR):
What: Claude Code
claude-fable-5,claude-opus-5How: triaged rad_aer_climate issue. verified populated values matched CAM
Description (include the issue title, and the keyword ['closes', 'fixes', 'resolves'] followed by the issue number):
Companion PR to ESCOMP/atmospheric_physics#439
Describe any changes made to build system: see below; added
CAM_SIM_YEARsupportDescribe any changes made to the namelist: namelist defaults were updated to include BAM by default and fix UNSET/'' empty-string for rad_aer_ values
List any changes to the defaults for the input datasets (e.g. boundary datasets):
List all files eliminated and why:
List all files added and what they do:
List all existing files that have been modified, and describe the changes:
(Helpful git command:
git diff --name-status development...<your_branch_name>)If there are new failures (compared to the
test/existing-test-failures.txtfile),have them OK'd by the gatekeeper, note them here, and add them to the file.
If there are baseline differences, include the test and the reason for the
diff. What is the nature of the change? Roundoff?
derecho/intel/aux_sima:
derecho/gnu/aux_sima:
derecho/nvhpc/aux_sima (test is run via Github workflow. Only run the test manually if we need to save new baselines):
If this changes climate describe any run(s) done to evaluate the new
climate in enough detail that it(they) could be reproduced:
Prescribed bulk aerosols now active for F-compsets of CAM4
CAM-SIMA date used for the baseline comparison tests if different than latest: