cam6_2_031: Aerosol convective processes by fvitt · Pull Request #149 · ESCOMP/CAM

fvitt · 2020-06-05T18:55:54Z

Refactor the implementation of resuspension of aerosols from rain to largest mode

Change to the calculation of convective vertical velocities of aerosols provided by Adam Herrington

Misc code clean up

Update to ChangeLog template

Fixes #140
Fixes #152

gold2718

Unless I'm missing something, there are new addfld calls with no corresponding outfld.

gold2718 · 2020-06-05T20:33:14Z

+   call addfld ('WUP', (/ 'lev' /), 'A', 'm/s','ZM vertical velocity')
+   call addfld ('DPFRAC', (/ 'lev' /), 'A', 'unitless','ZM cloud fraction')


It might be helpful to specify the process (in the long name).
Also, I do not see an outfld call for these fields.
Where are they (or remove them if they do not exist)?

These diagnostics were not implemented correctly. I removed these addfld calls.

gold2718 · 2020-06-05T22:22:53Z

      end do

-      ! Do resuspension of aerosols from rain to coarse mode (large particle) rather
+      ! Do resuspension of aerosols species from rain to coarse mode (large particle) rather


This seems like a correction. Is this correct or is it 'aerosol species'?

brian-eaton · 2020-06-06T00:36:26Z

               'Deep conv. cloudbase level index' )

+   call addfld ('WUP', (/ 'lev' /), 'A', 'm/s','ZM vertical velocity')
+   call addfld ('DPFRAC', (/ 'lev' /), 'A', 'unitless','ZM cloud fraction')


'unitless' is not a CF conforming unit (i.e., from udunits). Should be '1'

I also don't find the required outfld calls.

gold2718

All good now, thanks!

… mode modified: src/chemistry/modal_aero/modal_aero_convproc.F90 modified: src/chemistry/modal_aero/modal_aero_data.F90

modified: src/chemistry/modal_aero/modal_aero_convproc.F90 modified: src/chemistry/modal_aero/modal_aero_data.F90

modified: cime_config/testdefs/testlist_cam.xml modified: cime_config/testdefs/testmods_dirs/cam/outfrq9s_wetdep/user_nl_cam modified: src/chemistry/modal_aero/modal_aero_convproc.F90

modified: cime_config/testdefs/testmods_dirs/cam/outfrq9s_wetdep/user_nl_cam modified: src/chemistry/modal_aero/modal_aero_convproc.F90

cacraigucar · 2020-06-08T22:34:39Z

Requested rereview by @gold2718 as well for the ChangeLog_template mods.

nusbaume

It looks like one extra ChangeLog_Template line is missing.

gold2718

Looks good now, thanks for taking care of this.

cam6_2_031: Aerosol convective processes

Summary: Introduction of the ability to run with more complex atmospheric gas-phase chemistry. Contributors: Dirk Olivié Reviewers: Steve Goldhaber Purpose of changes: ESCOMP#100 Add trop+strat chemistry scheme. The new scheme is a combination of the aerosols from OSLO_AERO and the gas-phase species from the TS1 chemistry (pp_trop_strat_mam4_vbs). Github PR URL: NorESMhub#149 Changes made to build system: None Changes made to the namelist: - The namelist used by the new compsets contains elements from the standard aerosol-only NorESM namelist, but some external forcings have been removed as not used anymore (ozone climatology, ozone climatology, volcanic stratospheric AOD). - New things are : more emissions files are used, more GHGs/ODSs are prescribed, and the lightning NOx scaling factor is now used. - Concerning MEGAN fluxes from the land-model : more species are mapped into monoterpene (to make it more in line with CESM). - 3D-chemical species are taken into account in the radiation Changes to the defaults for the boundary datasets: - there are additional emission files - some climatologies are not used anymore (ozone, oxidants) Substantial timing or memory changes: an N1850_f19_tn14 simulation on 1024 CPUs is much slower. The throughput is 8.67 simulated years/day (compared to 19.84 simulated years/day in aerosol-only version) Detailed description of changes : General files : bld/config_files/definition.xml [new chemical package "tropstrat_mam_oslo] Files in specific chemistry directory pp_tropstrat_mam_oslo (generated by chemical preprocessor): Test run: ERP_D_Ln9.f19_f19_mtn14.NF1850norbc_tropstratchem.betzy_intel.cam-outfrq aux_cam_noresm tests are BFB except for this new test

fvitt added next release Required to be in next CESM Release bug-fix This PR was created to fix a specific bug. labels Jun 5, 2020

fvitt added this to the CESM2.2 milestone Jun 5, 2020

fvitt requested review from brian-eaton, cacraigucar, gold2718 and nusbaume June 5, 2020 18:55

fvitt self-assigned this Jun 5, 2020

gold2718 requested changes Jun 5, 2020

View reviewed changes

brian-eaton reviewed Jun 6, 2020

View reviewed changes

cacraigucar approved these changes Jun 8, 2020

View reviewed changes

nusbaume approved these changes Jun 8, 2020

View reviewed changes

brian-eaton approved these changes Jun 8, 2020

View reviewed changes

fvitt requested a review from gold2718 June 8, 2020 16:27

cacraigucar changed the title ~~Aerosol convective processes~~ cam6_2_031?: Aerosol convective processes Jun 8, 2020

gold2718 approved these changes Jun 8, 2020

View reviewed changes

cacraigucar changed the title ~~cam6_2_031?: Aerosol convective processes~~ cam6_2_031: Aerosol convective processes Jun 8, 2020

cacraigucar mentioned this pull request Jun 8, 2020

Update ChangeLog template to replace Bugzilla with Github #152

Closed

fvitt added 4 commits June 8, 2020 15:32

refactor code that does resuspension of aerosols from rain to largest…

25fc8fe

… mode modified: src/chemistry/modal_aero/modal_aero_convproc.F90 modified: src/chemistry/modal_aero/modal_aero_data.F90

clode clean up

2f44b32

modified: src/chemistry/modal_aero/modal_aero_convproc.F90 modified: src/chemistry/modal_aero/modal_aero_data.F90

updates to vertical velocity (wup) calculation from Adam Herrington

37d2d86

modified: cime_config/testdefs/testlist_cam.xml modified: cime_config/testdefs/testmods_dirs/cam/outfrq9s_wetdep/user_nl_cam modified: src/chemistry/modal_aero/modal_aero_convproc.F90

remove history addfld calls for WUP and DPFRAC

e315024

modified: cime_config/testdefs/testmods_dirs/cam/outfrq9s_wetdep/user_nl_cam modified: src/chemistry/modal_aero/modal_aero_convproc.F90

fvitt force-pushed the wet_removal_cam6_2_028 branch from 36b3ead to e315024 Compare June 8, 2020 21:33

updates to ChangeLog and ChangeLog_template

afb327f

fvitt requested review from cacraigucar and nusbaume June 8, 2020 22:24

cacraigucar approved these changes Jun 8, 2020

View reviewed changes

cacraigucar requested a review from gold2718 June 8, 2020 22:33

nusbaume requested changes Jun 8, 2020

View reviewed changes

Comment thread doc/ChangeLog_template

updates to ChangeLog and ChangeLog_template

988e6c9

fvitt requested review from cacraigucar and nusbaume June 8, 2020 23:14

gold2718 approved these changes Jun 8, 2020

View reviewed changes

cacraigucar approved these changes Jun 8, 2020

View reviewed changes

nusbaume approved these changes Jun 9, 2020

View reviewed changes

update ChangeLog

109cfde

fvitt merged commit 2f5a6af into ESCOMP:cam_development Jun 9, 2020

gold2718 removed the next release Required to be in next CESM Release label Jun 9, 2020

kettleofmonkeys pushed a commit to adamrher/CAM that referenced this pull request Oct 31, 2023

Merge pull request ESCOMP#149 from fvitt/wet_removal_cam6_2_028

cd6eba9

cam6_2_031: Aerosol convective processes

Navigation Menu

Uh oh!

cam6_2_031: Aerosol convective processes - #149

cam6_2_031: Aerosol convective processes#149
fvitt merged 7 commits into
ESCOMP:cam_developmentfrom
fvitt:wet_removal_cam6_2_028

fvitt commented Jun 5, 2020 •

edited

Loading

Uh oh!

gold2718 left a comment

Uh oh!

gold2718 Jun 5, 2020

Uh oh!

fvitt Jun 6, 2020 •

edited

Loading

Uh oh!

gold2718 Jun 5, 2020

Uh oh!

brian-eaton Jun 6, 2020

Uh oh!

gold2718 left a comment

Uh oh!

cacraigucar commented Jun 8, 2020

Uh oh!

nusbaume left a comment

Uh oh!

Uh oh!

gold2718 left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

		call addfld ('WUP', (/ 'lev' /), 'A', 'm/s','ZM vertical velocity')
		call addfld ('DPFRAC', (/ 'lev' /), 'A', 'unitless','ZM cloud fraction')

Uh oh!

Conversation

fvitt commented Jun 5, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gold2718 left a comment

Choose a reason for hiding this comment

Uh oh!

gold2718 Jun 5, 2020

Choose a reason for hiding this comment

Uh oh!

fvitt Jun 6, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gold2718 Jun 5, 2020

Choose a reason for hiding this comment

Uh oh!

brian-eaton Jun 6, 2020

Choose a reason for hiding this comment

Uh oh!

gold2718 left a comment

Choose a reason for hiding this comment

Uh oh!

cacraigucar commented Jun 8, 2020

Uh oh!

nusbaume left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

gold2718 left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

fvitt commented Jun 5, 2020 •

edited

Loading

fvitt Jun 6, 2020 •

edited

Loading