cam6_4_167: 1850 MTt4s namelist defaults#1534
Merged
Merged
Conversation
modified: src/chemistry/mozart/mo_jshort.F90
modified: bld/namelist_files/namelist_defaults_cam.xml modified: bld/namelist_files/use_cases/1850_trop_strat_t4s_cam7.xml
modified: bld/namelist_files/use_cases/1850_trop_strat_t4s_cam7.xml modified: src/chemistry/modal_aero/aero_model.F90 modified: src/chemistry/mozart/mo_chm_diags.F90 modified: src/chemistry/mozart/mo_extfrc.F90 modified: src/chemistry/mozart/mo_neu_wetdep.F90 modified: src/physics/cam/aerosol_optics_cam.F90 modified: src/physics/cam/ndrop.F90
modified: bld/namelist_files/use_cases/1850_trop_strat_t4s_cam7.xml modified: src/chemistry/modal_aero/aero_model.F90 modified: src/chemistry/mozart/mo_chm_diags.F90 modified: src/chemistry/mozart/mo_extfrc.F90 modified: src/chemistry/mozart/mo_neu_wetdep.F90 modified: src/physics/cam/aerosol_optics_cam.F90
Closed
modified: bld/namelist_files/namelist_defaults_cam.xml modified: bld/namelist_files/use_cases/1850_cam_lt.xml modified: bld/namelist_files/use_cases/1850_cam_mt.xml modified: bld/namelist_files/use_cases/1850_trop_strat_t4s_cam7.xml modified: bld/namelist_files/use_cases/hist_cam_lt.xml modified: bld/namelist_files/use_cases/hist_cam_mt.xml modified: bld/namelist_files/use_cases/waccm_ma_hist_cam7.xml modified: bld/namelist_files/use_cases/waccm_sc_hist_cam7.xml
cacraigucar
requested changes
Apr 21, 2026
cacraigucar
changed the title
cacraigucar
approved these changes
Apr 21, 2026
Collaborator
There was a problem hiding this comment.
This seems fine to me.
Collaborator
cecilehannay
left a comment
cecilehannay
left a comment
There was a problem hiding this comment.
The namelist changes for LTso and MTso seems fine to me. I don't have an opinions on the otehr changes about waccm, and t4s or the files in chemistry/mozart
Collaborator
There was a problem hiding this comment.
I have no clue whether this is correct or not. I will let Simone or someone else reviews this
tilmes
reviewed
Apr 22, 2026
| 'vertically intergrated external forcing for '//trim(spc_name) ) | ||
| if ( history_aerosol .or. history_chemistry ) then | ||
| call add_default( trim(spc_name)//'_CLXF', 1, ' ' ) | ||
| call add_default( trim(spc_name)//'_CMXF', 1, ' ' ) |
Collaborator
There was a problem hiding this comment.
Could we leave CMXF, I think, that is used for the diagnostics
modified: src/chemistry/mozart/mo_extfrc.F90
tilmes
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates 1850 MTt4s build-namelist use case and
history_aero_opticsdefault history output. Also adds some error checking for realistic O2 concentrations pass tomo_jshort.Closes #1527
Closes #1528
Closes #1539