Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2939 +/- ##
=======================================
Coverage 95.59% 95.59%
=======================================
Files 266 266
Lines 15573 15573
=======================================
Hits 14887 14887
Misses 686 686 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
1208dad to
ea18317
Compare
Member
Author
|
Tests are failing due to #2940 |
bouweandela
commented
Jan 13, 2026
valeriupredoi
approved these changes
Jan 13, 2026
Contributor
valeriupredoi
left a comment
There was a problem hiding this comment.
looks good, could you trigger a dry run by running the GHA test on this branch please? 🍻
| Issues = "https://github.com/ESMValGroup/ESMValCore/issues" | ||
|
|
||
| [tool.setuptools] | ||
| include-package-data = true |
Member
Author
There was a problem hiding this comment.
Because it's the default these days
Contributor
|
ah nevermind, you ran it here - thanks, bud 🍺 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Link to documentation: https://esmvaltool--2939.org.readthedocs.build/projects/ESMValCore/en/2939/how-to/how-to-make-a-release.html#create-and-upload-the-pypi-package
Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
To help with the number pull requests: