Skip to content

Update PyPI publish action#2939

Merged
valeriupredoi merged 5 commits intomainfrom
update-publish-action
Jan 13, 2026
Merged

Update PyPI publish action#2939
valeriupredoi merged 5 commits intomainfrom
update-publish-action

Conversation

@bouweandela
Copy link
Member

@bouweandela bouweandela commented Jan 8, 2026

Description

Link to documentation: https://esmvaltool--2939.org.readthedocs.build/projects/ESMValCore/en/2939/how-to/how-to-make-a-release.html#create-and-upload-the-pypi-package


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.


To help with the number pull requests:

@bouweandela bouweandela added installation Installation problem testing labels Jan 8, 2026
@codecov
Copy link

codecov bot commented Jan 8, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.59%. Comparing base (a551618) to head (17d95a2).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2939   +/-   ##
=======================================
  Coverage   95.59%   95.59%           
=======================================
  Files         266      266           
  Lines       15573    15573           
=======================================
  Hits        14887    14887           
  Misses        686      686           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bouweandela bouweandela force-pushed the update-publish-action branch from 1208dad to ea18317 Compare January 8, 2026 12:59
@bouweandela
Copy link
Member Author

Tests are failing due to #2940

@bouweandela bouweandela marked this pull request as ready for review January 13, 2026 13:52
Copy link
Contributor

@valeriupredoi valeriupredoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, could you trigger a dry run by running the GHA test on this branch please? 🍻

Issues = "https://github.com/ESMValGroup/ESMValCore/issues"

[tool.setuptools]
include-package-data = true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why removing this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because it's the default these days

@valeriupredoi
Copy link
Contributor

valeriupredoi commented Jan 13, 2026

ah nevermind, you ran it here - thanks, bud 🍺
https://github.com/ESMValGroup/ESMValCore/actions/runs/20956525633/job/60222454804

@valeriupredoi valeriupredoi merged commit f0b9561 into main Jan 13, 2026
4 checks passed
@valeriupredoi valeriupredoi deleted the update-publish-action branch January 13, 2026 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

installation Installation problem testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants