Expand ICON-XPP fix for new model version#3014
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3014 +/- ##
=======================================
Coverage 95.69% 95.70%
=======================================
Files 267 267
Lines 15758 15768 +10
=======================================
+ Hits 15080 15090 +10
Misses 678 678 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
axel-lauer
approved these changes
Mar 10, 2026
Contributor
axel-lauer
left a comment
There was a problem hiding this comment.
I tested this with ocean and sea ice data. Works nicely! Thanks @schlunma!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I found two changes in ICON-XPP output that require changes in our on-the-fly CMORization:
ice_classinstead oflevdepthanddepth_2coordinates have been switched (one is cell centers, one cell boundaries)All changes here are fully backwards-compatible.
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
To help with the number pull requests: