Skip to content

Expand ICON-XPP fix for new model version#3014

Merged
schlunma merged 6 commits intomainfrom
expand_icon_xpp_fix
Mar 10, 2026
Merged

Expand ICON-XPP fix for new model version#3014
schlunma merged 6 commits intomainfrom
expand_icon_xpp_fix

Conversation

@schlunma
Copy link
Contributor

@schlunma schlunma commented Mar 10, 2026

Description

I found two changes in ICON-XPP output that require changes in our on-the-fly CMORization:

  • Sea ice data has depth variable ice_class instead of lev
  • The depth and depth_2 coordinates have been switched (one is cell centers, one cell boundaries)

All changes here are fully backwards-compatible.


Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.


To help with the number pull requests:

@schlunma schlunma requested a review from axel-lauer March 10, 2026 13:11
@schlunma schlunma added the fix for dataset Related to dataset-specific fix files label Mar 10, 2026
@codecov
Copy link

codecov bot commented Mar 10, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.70%. Comparing base (6a382f6) to head (347d973).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3014   +/-   ##
=======================================
  Coverage   95.69%   95.70%           
=======================================
  Files         267      267           
  Lines       15758    15768   +10     
=======================================
+ Hits        15080    15090   +10     
  Misses        678      678           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@axel-lauer axel-lauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this with ocean and sea ice data. Works nicely! Thanks @schlunma!

@schlunma schlunma merged commit b93b706 into main Mar 10, 2026
4 checks passed
@schlunma schlunma deleted the expand_icon_xpp_fix branch March 10, 2026 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix for dataset Related to dataset-specific fix files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants