Skip to content

Improve code quality and test coverage#3029

Merged
schlunma merged 6 commits intomainfrom
improve_code_style_and_cov
Mar 26, 2026
Merged

Improve code quality and test coverage#3029
schlunma merged 6 commits intomainfrom
improve_code_style_and_cov

Conversation

@schlunma
Copy link
Contributor

@schlunma schlunma commented Mar 25, 2026

Description

While working on #3025, I noticed that we often have the pattern

msg = "error message"
raise Exception(
    msg,
)

in our code base, which has been introduced by Ruff. This PR fixes this.

It also improves our test coverage by adding missing tests for the changed lines (thanks Claude!).


Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.


To help with the number pull requests:

@schlunma schlunma added this to the v2.15.0 milestone Mar 25, 2026
@schlunma schlunma added the enhancement New feature or request label Mar 25, 2026
@codecov
Copy link

codecov bot commented Mar 25, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.14%. Comparing base (9e24b51) to head (5578a33).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3029      +/-   ##
==========================================
+ Coverage   95.70%   96.14%   +0.44%     
==========================================
  Files         267      267              
  Lines       15768    15768              
==========================================
+ Hits        15090    15160      +70     
+ Misses        678      608      -70     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@schlunma schlunma marked this pull request as ready for review March 26, 2026 11:32
Copy link
Contributor

@valeriupredoi valeriupredoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks Manu 🍻

@schlunma schlunma merged commit 51b8c0d into main Mar 26, 2026
4 checks passed
@schlunma schlunma deleted the improve_code_style_and_cov branch March 26, 2026 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants