Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3030 +/- ##
=======================================
Coverage 95.70% 95.70%
=======================================
Files 267 267
Lines 15768 15771 +3
=======================================
+ Hits 15090 15093 +3
Misses 678 678 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
4a1b597 to
0ca6679
Compare
|
Are the differing calendars a problem when concatenating legacy data and new data? |
It does not seem like it. The calendars are changed again when concatenating the cubes by I have managed to run some diagnostics with ERA5 spanning 1980-2025 (2024 and 2025 being downloaded with the new version), and the preprocessed data looks fine e.g. for JJA temperature data: |
schlunma
left a comment
There was a problem hiding this comment.
Ah, that makes sense! I wasn't aware that our concantenation can change calendars!
Looks good to me, just one tiny comment.
Co-authored-by: Manuel Schlund <32543114+schlunma@users.noreply.github.com>
Description
ECMWF is now using a different netCDF converter for the ERA5 GRIB files available on the CDS and ADS systems. These changes notably involve modifications in the coordinates (notably time and latitude) that can lead to errors when using newly downloaded ERA5 data. The detailed description of the modifications can be found on the ECMWF Confluence page here.
This PR aims to tackle two identified issues:
"hours since 1900-01-01 00:00:00.0, gregorian"to"seconds since 1970-01-01, proleptic_gregorian"which leads to an error when converting the time unit in the ERA5_fix_coordinatesmethod.stored_directionwhich leads to an error when trying to concatenate data files from the legacy and the new version because of differing metadata in the iris cubes.esmvalcore.cmor._fixes.fix._fix_coord_directionCloses #3026
Link to documentation:
Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
To help with the number pull requests: