UCAAS-1333: snacclib7 ROSE handler and invoke context improvements#133
Merged
JanFellner merged 1 commit intoJul 3, 2026
Merged
Conversation
- Improve readability of esnacc-generated ROSE invoke handlers (gen-code.c) - Require callers to pass SnaccInvokeContext into SendRejectEx for decode-error rejects - Route OnInvokeMessage, SendEvent, and SendInvoke through CreateInvokeContext() for transport subclasses - Document SendInvoke iTimeout in milliseconds on SnaccROSESender and SnaccROSEBase - Bump version to 7.0.5 (release date 03.07.2026) Made-with: Cursor
JanFellner
force-pushed
the
feature/UCAAS-1333-improve-generated-rose-handlers
branch
from
9501ea4 to
ff0c2ee
Compare
JanFellner
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
UCAAS-1333 snacclib7 / esnacc improvements (single squashed commit
ff0c2ee):lRoseResultfromDecodeInvokeand use an explicitdefaultcase inOnInvokeSnaccInvokeContextintoSendRejectExso decode-error rejects use inbound invoke context instead of an empty outbound contextOnInvokeMessage,SendEvent, andSendInvokethroughCreateInvokeContext()so transport subclasses can supply custom invoke contextsSendInvokeiTimeoutin milliseconds onSnaccROSESenderandSnaccROSEBase(-1 → defaultm_lMaxInvokeWait, 0 → fire-and-forget)Test plan
cpp-libandcompilerlocallycpp-lib-sample-runtime-tests