Fix Tracking completion badges and stop icon colors#119
Merged
Conversation
Constraint: Tracking completion visuals must follow server completedStopIds only Rejected: Persisted delivery/order status fallback | it can mark unfinished Tracking stops complete Confidence: high Scope-risk: narrow Directive: Preserve tracking-only completion semantics for map badges and list icons Tested: 358 node tests; typecheck; production build; ESLint; public URL guard Not-tested: Browser interaction against a newly delivered production stop
OziinG
marked this pull request as ready for review
July 23, 2026 14:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
completedStopIdsfor completion badgesDELIVEREDstate without a Tracking completion eventRoot cause
The UI merged persisted order/delivery status into the Tracking completion set, and the map feature builder independently treated persisted delivery status as completed. Either path could show a green check before Tracking actually completed the stop.
Impact
Tracking completion visuals now follow the live/historical Tracking lifecycle only. The Stops view keeps its existing persisted-status presentation.
Validation