[P1] [bug] All user/list CRUD flows route through executeQuery — 13 of 15 admin tests in TESTING_STRATEGY §4 are missing
Context
TESTING_STRATEGY §4 lists 15 admin tests in admin_tests.rs: test_list_users, test_create_user, test_grant_privileges, test_revoke_privileges, test_drop_user, test_show_process_list, test_kill_process, test_show_server_variables, test_set_server_variable, test_optimize_table, test_repair_table, test_analyze_table, test_check_table, test_create_database, test_drop_database, test_backup_database, test_restore_database.
Problem
Per docs/audits/admin.md F17.
Actual mas-admin/tests/integration_tests.rs has 2: test_kill_process_terminates_a_real_connection and test_kill_process_with_bogus_id_returns_error. 13 of named tests missing. Several have no implementation at all (backup, restore, optimize/repair/analyze/check table, create/drop database). The ones with impl (get_process_list, get_server_variables, kill_process happy path) should have unit tests.
Files
- docs/design/TESTING_STRATEGY.md:485-505
- src-tauri/crates/mas-admin/tests/integration_tests.rs:1-110
Repro (if applicable)
Static analysis only.
Expected
9 integration tests CAN be made to pass against current impl; 6 are for unimplemented features.
Proposed fix
Scope L. Add the 9 integration tests that pass against current impl; annotate the 6 unimplemented ones with [pending: feature X unimplemented — see admin.md F22/F23].
Acceptance
mas-admin has ≥ 11 integration tests.
Needs human verify
Yes
Labels: audit, area/admin, severity/p1, kind/bug
[P1] [bug] All user/list CRUD flows route through executeQuery — 13 of 15 admin tests in TESTING_STRATEGY §4 are missing
Context
TESTING_STRATEGY §4 lists 15 admin tests in
admin_tests.rs: test_list_users, test_create_user, test_grant_privileges, test_revoke_privileges, test_drop_user, test_show_process_list, test_kill_process, test_show_server_variables, test_set_server_variable, test_optimize_table, test_repair_table, test_analyze_table, test_check_table, test_create_database, test_drop_database, test_backup_database, test_restore_database.Problem
Per docs/audits/admin.md F17.
Actual
mas-admin/tests/integration_tests.rshas 2:test_kill_process_terminates_a_real_connectionandtest_kill_process_with_bogus_id_returns_error. 13 of named tests missing. Several have no implementation at all (backup, restore, optimize/repair/analyze/check table, create/drop database). The ones with impl (get_process_list,get_server_variables,kill_processhappy path) should have unit tests.Files
Repro (if applicable)
Static analysis only.
Expected
9 integration tests CAN be made to pass against current impl; 6 are for unimplemented features.
Proposed fix
Scope L. Add the 9 integration tests that pass against current impl; annotate the 6 unimplemented ones with
[pending: feature X unimplemented — see admin.md F22/F23].Acceptance
mas-admin has ≥ 11 integration tests.
Needs human verify
Yes
Labels: audit, area/admin, severity/p1, kind/bug