fix(artifact): reject Windows path escapes in store keys - #123
Draft
cursor[bot] wants to merge 3 commits into
Draft
fix(artifact): reject Windows path escapes in store keys#123cursor[bot] wants to merge 3 commits into
cursor[bot] wants to merge 3 commits into
Conversation
Harden artifact key/run_id validation against drive-absolute and backslash-rooted paths, and refuse joined paths that leave the store root. Co-authored-by: EXboy <EXboys@users.noreply.github.com>
Co-authored-by: EXboy <EXboys@users.noreply.github.com>
Record validation results, mark TASK-2026-071 done, and sync the board. Co-authored-by: EXboy <EXboys@users.noreply.github.com>
17 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
key/run_idvalues that previously passed Unix-oriented validation and escaped the store root viaPath::joinon Windows.LocalDirArtifactStoreso resolved paths must remain under<base>/artifacts.C:\...,C:/..., and\Windows\Temp-style inputs while keeping/hierarchical keys working.Task Linkage
TASK-2026-071tasks/TASK-2026-071-artifact-windows-path-escape/Injected Specs
spec/architecture-boundaries.mdspec/security-nonnegotiables.mdspec/testing-policy.mdspec/docs-sync.mdValidation Evidence
cargo fmt --checkcargo test -p skilllite-core artifact_storecargo test -p skilllite-artifactcargo testcargo clippy -p skilllite-core -p skilllite-artifact --all-targets -- -D warningscargo clippy --all-targets -- -D warnings -A clippy::question_mark -A clippy::useless_borrows_in_formattingpython3 scripts/validate_tasks.pyskilllite-artifacttests: 26 passed.cargo test: passed.-D warnings.skilllite-commands(question_mark,useless_borrows_in_formatting).71 task directories checked.Regression Scope
artifact-serve.Docs Sync (EN/ZH)
/-separated paths as previously documented.Review Checklist
tasks/TASK-2026-071-artifact-windows-path-escape/TASK.mdsatisfiedtasks/TASK-2026-071-artifact-windows-path-escape/STATUS.mdupdated with latest progresstasks/TASK-2026-071-artifact-windows-path-escape/REVIEW.mdincludes merge readiness decisiontasks/board.mdstatus is up to date