fix(evolution): reject path-escaping skill entry points - #127
Draft
cursor[bot] wants to merge 2 commits into
Draft
fix(evolution): reject path-escaping skill entry points#127cursor[bot] wants to merge 2 commits into
cursor[bot] wants to merge 2 commits into
Conversation
LLM-controlled entry_point/name values were joined under _pending without containment checks, so absolute or ../ paths could write scripts outside the skill directory during synthesis. Co-authored-by: EXboy <EXboys@users.noreply.github.com>
Record validation results, mark TASK-2026-075 done, and silence the join_absolute_paths lint in the intentional Path::join precondition test. Co-authored-by: EXboy <EXboys@users.noreply.github.com>
This was referenced Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
skill.entry_point(and generated skillname) were joined under_evolved/_pendingwithout containment checks. Absolute entry points (e.g./tmp/pwn.py) replace the skill directory viaPath::join, and../components escape it beforeskilllite_fs::write_filewrites script content during evolution synthesis.validate_generated_skill_name+script_path_under_skill_dir, wires them into generate/refine/repair/infer, and keeps legitimate nested relatives likescripts/main.pyworking.Bug Impact
evolution run/ skill synthesis.entry_point: "/tmp/pwn.py"(or../../../tmp/pwn.py) with script content that passes L3/L4 gates.Task Linkage
TASK-2026-075tasks/TASK-2026-075-evolution-entry-point-path-safety/Injected Specs
spec/verification-integrity.mdspec/task-artifact-language.mdspec/security-nonnegotiables.mdspec/rust-conventions.mdspec/testing-policy.mdspec/docs-sync.md(N/A: fail-closed validation only; no user-facing path grammar docs)spec/architecture-boundaries.md(reviewed; no boundary changes)Validation Evidence
cargo test -p skilllite-evolution path_safety -- --nocapture→ 5 passedcargo test -p skilllite-evolution→ 99 passedcargo clippy -p skilllite-evolution --all-targets -- -D warnings→ cleancargo fmt --check -p skilllite-evolution→ cleanpython3 scripts/validate_tasks.py→ passed (71 task directories)/tmp/pwn.pyand traversal../../../tmp/pwn.pyrejectedscripts/main.pystill acceptedRegression Scope
skill_namehardening (open PR fix(evolution): constrain pending skill path operations #89)Docs Sync (EN/ZH)
Files:
Security Review Notes
SKILLLITE_*config semantics? No.Review Checklist
tasks/TASK-2026-075-evolution-entry-point-path-safety/TASK.mdsatisfiedtasks/TASK-2026-075-evolution-entry-point-path-safety/STATUS.mdupdated with latest progresstasks/TASK-2026-075-evolution-entry-point-path-safety/REVIEW.mdincludes merge readiness decisiontasks/board.mdstatus is up to date