fix(openclaw): reject path-escaping import skill names - #131
Draft
cursor[bot] wants to merge 2 commits into
Draft
Conversation
Validate OpenClaw SKILL.md frontmatter names as a single path segment before joining under the skills root, so absolute or ../ names cannot escape during import-openclaw-skills / claw migrate skill copy. Co-authored-by: EXboy <EXboys@users.noreply.github.com>
Finalize TASK-2026-079 evidence, review readiness, and board status after path-validation and import regression tests passed. Co-authored-by: EXboy <EXboys@users.noreply.github.com>
16 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
skilllite import-openclaw-skills(andclaw migrateskill import): SKILL.md frontmatternamewas joined under the skills root without single-segment validation, so absolute or../names could install outsideskills/.validate_skill_dir_name/skill_dir_under_roothelpers (aligned with open PR fix(security): reject path-escaping skill directory names #125) and fail-closed skip of unsafe destinations before copy.Task Linkage
TASK-2026-079tasks/TASK-2026-079-openclaw-import-dest-name-safety/Injected Specs
spec/verification-integrity.mdspec/task-artifact-language.mdspec/security-nonnegotiables.mdspec/rust-conventions.mdspec/testing-policy.mdspec/docs-sync.md(reviewed; no docs needed — fail-closed validation only)Validation Evidence
cargo test -p skilllite-core path_validationcargo test -p skilllite-commands import_cargo fmt --checkcargo clippy -p skilllite-core -p skilllite-commands --all-targets -- -D warnings -A dead_code -A clippy::question_mark -A clippy::useless_borrows_in_formattingpython3 scripts/validate_tasks.py3 passed4 passed(relative + absolute escape skipped; safe skill still installed)Task validation passed (71 task folders checked)Regression Scope
import-openclaw-skillsdestination selectionclaw migrateskill import (delegates to the same command)skilllite add/ MCP / CLI lookup validation (open PR fix(security): reject path-escaping skill directory names #125)Docs Sync (EN/ZH)
Review Checklist
tasks/TASK-2026-079-openclaw-import-dest-name-safety/TASK.mdsatisfiedtasks/TASK-2026-079-openclaw-import-dest-name-safety/STATUS.mdupdated with latest progresstasks/TASK-2026-079-openclaw-import-dest-name-safety/REVIEW.mdincludes merge readiness decisiontasks/board.mdstatus is up to dateSecurity review notes
SKILLLITE_*config semantics or backward compatibility? No env/config change; only rejects previously unsafe multi-segment/absolute names.