Skip to content

fix: pass empty updater signing password safely - #35

Merged
EaeDave merged 2 commits into
mainfrom
fix/release-signer-empty-password
Aug 14, 2026
Merged

fix: pass empty updater signing password safely#35
EaeDave merged 2 commits into
mainfrom
fix/release-signer-empty-password

Conversation

@EaeDave

@EaeDave EaeDave commented Aug 14, 2026

Copy link
Copy Markdown
Owner

Summary

  • preserve an explicitly empty updater-key password as one CLI argument
  • prevent the Linux artifact path from being parsed as the password

Validation

  • signed the packaged Linux updater binary using the persistent local release key
  • bunx tsc --noEmit
  • git diff --check

This fixes the release preflight failure discovered immediately after merging #34.


Summary by cubic

Fixes Linux updater signing when TAURI_SIGNING_PRIVATE_KEY_PASSWORD is intentionally empty. Previously -p "" caused the next arg (the artifact path) to be parsed as the password; now we pass --password= inline so an empty password stays empty and the path is not consumed.

  • Change: in scripts/release.ts, use --password=${TAURI_SIGNING_PRIVATE_KEY_PASSWORD ?? ""} for tauri signer sign.
  • Scope: affects only the Linux updater signing step; macOS/Windows unchanged.
  • Review: confirm tauri signer accepts the --password= form; other file changes are generated graph refresh.
  • Rollout: no config changes; pipelines with an empty TAURI_SIGNING_PRIVATE_KEY_PASSWORD will now pass.

Written for commit 88d0cc8. Summary will update on new commits.

Review in cubic

@coderabbitai

coderabbitai Bot commented Aug 14, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@EaeDave, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 2 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: fc9868d5-221d-433e-a7bb-b150b7e2805d

📥 Commits

Reviewing files that changed from the base of the PR and between 15081b6 and 88d0cc8.

⛔ Files ignored due to path filters (8)
  • graphify-out/2026-08-14/.graphify_labels.json is excluded by !graphify-out/**
  • graphify-out/2026-08-14/GRAPH_REPORT.md is excluded by !graphify-out/**
  • graphify-out/2026-08-14/graph.json is excluded by !graphify-out/**
  • graphify-out/2026-08-14/manifest.json is excluded by !graphify-out/**
  • graphify-out/GRAPH_REPORT.md is excluded by !graphify-out/**
  • graphify-out/graph.html is excluded by !graphify-out/**
  • graphify-out/graph.json is excluded by !graphify-out/**
  • graphify-out/manifest.json is excluded by !graphify-out/**
📒 Files selected for processing (1)
  • scripts/release.ts

Comment @coderabbitai help to get the list of available commands.

@EaeDave
EaeDave merged commit eb9034a into main Aug 14, 2026
2 checks passed
@EaeDave
EaeDave deleted the fix/release-signer-empty-password branch August 14, 2026 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant