fix: pass empty updater signing password safely - #35
Conversation
|
Warning Review limit reached
Next review available in: 2 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (8)
📒 Files selected for processing (1)
Comment |
Summary
Validation
bunx tsc --noEmitgit diff --checkThis fixes the release preflight failure discovered immediately after merging #34.
Summary by cubic
Fixes Linux updater signing when
TAURI_SIGNING_PRIVATE_KEY_PASSWORDis intentionally empty. Previously-p ""caused the next arg (the artifact path) to be parsed as the password; now we pass--password=inline so an empty password stays empty and the path is not consumed.scripts/release.ts, use--password=${TAURI_SIGNING_PRIVATE_KEY_PASSWORD ?? ""}fortauri signer sign.tauri signeraccepts the--password=form; other file changes are generated graph refresh.TAURI_SIGNING_PRIVATE_KEY_PASSWORDwill now pass.Written for commit 88d0cc8. Summary will update on new commits.