fix(earthfile2llb): make command rename warning thread-safe - #788
fix(earthfile2llb): make command rename warning thread-safe#788janishorsts wants to merge 3 commits into
Conversation
➖ Are we earthbuild yet?No change in "earthly" occurrences 📈 Overall Progress
Keep up the great work migrating from Earthly to Earthbuild! 🚀 💡 Tips for finding more occurrencesRun locally to see detailed breakdown: ./.github/scripts/count-earthly.shNote that the goal is not to reach 0. |
|
── nits ─────────────────────────────────────────────────── ⚠︎ 1 · The concurrency test can't fail. earthfile2llb/interpreter_test.go:44 asserts nothing, and Earthfile:211 runs go test -timeout 5m -json — no |
Signed-off-by: Giles Cope <gilescope@gmail.com>
@gilescope, I'm going to refactor it as this fixes the symptom, not the underlying issue: the grammar deprecation warnings belong to the parsing process. |
Fixes #787