Skip to content

book signing #801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Earthcomputer merged 4 commits into from
Jul 21, 2026
Merged

book signing #801

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
40a94c8
book signing
xcfrg Jul 6, 2026
f0cdb51
address feedback
xcfrg Jul 8, 2026
8379531
Restore old syntax of /cbook
xpple Jul 21, 2026
cd865da
Add back version check
xpple Jul 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
100 changes: 66 additions & 34 deletions src/main/java/net/earthcomputer/clientcommands/command/BookCommand.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
import net.minecraft.world.item.ItemStack;
import net.minecraft.world.item.Items;
import net.minecraft.world.item.component.WritableBookContent;
import net.minecraft.world.item.component.WrittenBookContent;

import java.util.ArrayList;
import java.util.List;
Expand All @@ -26,35 +27,40 @@

import static com.mojang.brigadier.arguments.IntegerArgumentType.*;
import static com.mojang.brigadier.arguments.LongArgumentType.*;
import static com.mojang.brigadier.arguments.StringArgumentType.*;
import static net.fabricmc.fabric.api.client.command.v2.ClientCommands.*;

public class BookCommand {
private static final SimpleCommandExceptionType NO_BOOK = new SimpleCommandExceptionType(Component.translatable("commands.cbook.commandException"));
private static final SimpleCommandExceptionType TITLE_TOO_LONG = new SimpleCommandExceptionType(Component.translatable("commands.cbook.titleTooLong", WrittenBookContent.TITLE_MAX_LENGTH));

private static final int DEFAULT_LIMIT = 50;

public static void register(CommandDispatcher<FabricClientCommandSource> dispatcher) {
if (MultiVersionCompat.INSTANCE.getProtocolVersion() >= MultiVersionCompat.V1_15) {
return; // chunk savestate fixed in 1.15
}

dispatcher.register(literal("cbook")
.then(literal("fill")
.executes(ctx -> fillBook(ctx.getSource(), fill(), DEFAULT_LIMIT))
.then(argument("limit", integer(0, getMaxLimit()))
.executes(ctx -> fillBook(ctx.getSource(), fill(), getInteger(ctx, "limit")))))
.then(literal("random")
.executes(ctx -> fillBook(ctx.getSource(), random(new Random()), DEFAULT_LIMIT))
.then(argument("limit", integer(0, getMaxLimit()))
.executes(ctx -> fillBook(ctx.getSource(), random(new Random()), getInteger(ctx, "limit")))
.then(argument("seed", longArg())
.executes(ctx -> fillBook(ctx.getSource(), random(new Random(getLong(ctx, "seed"))), getInteger(ctx, "limit"))))))
.then(literal("ascii")
.executes(ctx -> fillBook(ctx.getSource(), ascii(new Random()), DEFAULT_LIMIT))
.then(argument("limit", integer(0, getMaxLimit()))
.executes(ctx -> fillBook(ctx.getSource(), ascii(new Random()), getInteger(ctx, "limit")))
.then(argument("seed", longArg())
.executes(ctx -> fillBook(ctx.getSource(), ascii(new Random(getLong(ctx, "seed"))), getInteger(ctx, "limit")))))));
.then(literal("sign")
.executes(ctx -> signBook(ctx.getSource(), ""))
.then(argument("title", greedyString())
.executes(ctx -> signBook(ctx.getSource(), getString(ctx, "title")))))
.then(literal("fill")
.requires(_ -> MultiVersionCompat.INSTANCE.getProtocolVersion() < MultiVersionCompat.V1_15)
.executes(ctx -> fillBook(ctx.getSource(), fill(), DEFAULT_LIMIT))
.then(argument("limit", integer(0, getMaxLimit()))
.executes(ctx -> fillBook(ctx.getSource(), fill(), getInteger(ctx, "limit")))))
.then(literal("random")
.requires(_ -> MultiVersionCompat.INSTANCE.getProtocolVersion() < MultiVersionCompat.V1_15)
.executes(ctx -> fillBook(ctx.getSource(), random(new Random()), DEFAULT_LIMIT))
.then(argument("limit", integer(0, getMaxLimit()))
.executes(ctx -> fillBook(ctx.getSource(), random(new Random()), getInteger(ctx, "limit")))
.then(argument("seed", longArg())
.executes(ctx -> fillBook(ctx.getSource(), random(new Random(getLong(ctx, "seed"))), getInteger(ctx, "limit"))))))
.then(literal("ascii")
.requires(_ -> MultiVersionCompat.INSTANCE.getProtocolVersion() < MultiVersionCompat.V1_15)
.executes(ctx -> fillBook(ctx.getSource(), ascii(new Random()), DEFAULT_LIMIT))
.then(argument("limit", integer(0, getMaxLimit()))
.executes(ctx -> fillBook(ctx.getSource(), ascii(new Random()), getInteger(ctx, "limit")))
.then(argument("seed", longArg())
.executes(ctx -> fillBook(ctx.getSource(), ascii(new Random(getLong(ctx, "seed"))), getInteger(ctx, "limit")))))));
}

private static IntStream fill() {
Expand All @@ -71,20 +77,12 @@ private static IntStream ascii(Random rand) {

private static int fillBook(FabricClientCommandSource source, IntStream characterGenerator, int limit) throws CommandSyntaxException {
LocalPlayer player = source.getPlayer();
assert player != null;

ItemStack heldItem = player.getMainHandItem();
InteractionHand hand = InteractionHand.MAIN_HAND;
if (heldItem.getItem() != Items.WRITABLE_BOOK) {
heldItem = player.getOffhandItem();
hand = InteractionHand.OFF_HAND;
if (heldItem.getItem() != Items.WRITABLE_BOOK) {
throw NO_BOOK.create();
}
}
int slot = hand == InteractionHand.MAIN_HAND ? player.getInventory().getSelectedSlot() : Inventory.SLOT_OFFHAND;
HeldBook book = getHeldWritableBook(player);

String joinedPages = characterGenerator.limit((long) getMaxLimit() * 210).mapToObj(i -> String.valueOf((char) i)).collect(Collectors.joining());
String joinedPages = characterGenerator.limit((long) getMaxLimit() * 210)
.mapToObj(i -> String.valueOf((char) i))
.collect(Collectors.joining());

List<String> pages = new ArrayList<>(limit);
List<Filterable<String>> filterablePages = new ArrayList<>();
Expand All @@ -95,15 +93,49 @@ private static int fillBook(FabricClientCommandSource source, IntStream characte
filterablePages.add(Filterable.passThrough(page));
}

heldItem.set(DataComponents.WRITABLE_BOOK_CONTENT, new WritableBookContent(filterablePages));
player.connection.send(new ServerboundEditBookPacket(slot, pages, Optional.empty()));
book.stack().set(DataComponents.WRITABLE_BOOK_CONTENT, new WritableBookContent(filterablePages));
player.connection.send(new ServerboundEditBookPacket(book.slot(), pages, Optional.empty()));

source.sendFeedback(Component.translatable("commands.cbook.success"));

return Command.SINGLE_SUCCESS;
}

private static int signBook(FabricClientCommandSource source, String title) throws CommandSyntaxException {
LocalPlayer player = source.getPlayer();

if (title.length() > WrittenBookContent.TITLE_MAX_LENGTH) {
throw TITLE_TOO_LONG.create();
}

HeldBook book = getHeldWritableBook(player);
WritableBookContent content = book.stack().get(DataComponents.WRITABLE_BOOK_CONTENT);
List<String> pages = content == null ? List.of() : content.getPages(false).toList();

player.connection.send(new ServerboundEditBookPacket(book.slot(), pages, Optional.of(title)));
source.sendFeedback(Component.translatable("commands.cbook.success"));

return Command.SINGLE_SUCCESS;
}

private static HeldBook getHeldWritableBook(LocalPlayer player) throws CommandSyntaxException {
ItemStack heldItem = player.getMainHandItem();
InteractionHand hand = InteractionHand.MAIN_HAND;
if (heldItem.getItem() != Items.WRITABLE_BOOK) {
heldItem = player.getOffhandItem();
hand = InteractionHand.OFF_HAND;
if (heldItem.getItem() != Items.WRITABLE_BOOK) {
throw NO_BOOK.create();
}
}
int slot = hand == InteractionHand.MAIN_HAND ? player.getInventory().getSelectedSlot() : Inventory.SLOT_OFFHAND;
return new HeldBook(heldItem, slot);
}

private static int getMaxLimit() {
return MultiVersionCompat.INSTANCE.getProtocolVersion() < MultiVersionCompat.V1_14 ? 50 : 100;
}

private record HeldBook(ItemStack stack, int slot) {
}
}
1 change: 1 addition & 0 deletions src/main/resources/assets/clientcommands/lang/en_us.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@

"commands.cbook.commandException": "You are not holding a book",
"commands.cbook.success": "Successfully edited book",
"commands.cbook.titleTooLong": "Book title cannot be longer than %s characters",

"commands.cbuildinfo.success": "Running clientcommands on version %s (%s@{%s})",

Expand Down
Loading